Skip to content

Commit c72b1ee

Browse files
committed
fix():
1 parent 5480b61 commit c72b1ee

12 files changed

+144
-4241
lines changed

src/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-webrtc-plugin",
3-
"version": "2.0.0-alpha.7",
3+
"version": "2.0.0-alpha.9",
44
"description": "WebRTC for NativeScript",
55
"main": "webrtc",
66
"typings": "index.d.ts",
224 Bytes
Binary file not shown.

src/src/android/TNSRTCPeerConnection.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,13 @@ export class TNSRTCPeerConnection {
150150
}
151151

152152
public addTrack(track: TNSRTCMediaStreamTrack, streamIds: Array<string>) {
153-
const ids = new java.util.ArrayList();
154-
for (let id of streamIds) {
155-
ids.add(id);
153+
if(streamIds){
154+
const ids = new java.util.ArrayList();
155+
for (let id of streamIds) {
156+
ids.add(id);
157+
}
158+
this.android.addTrack(track.mediaStreamTrack, ids);
156159
}
157-
this.android.addTrack(track.mediaStreamTrack, ids);
158160
}
159161

160162
public close() {

src/src/android/TNSRTCTrackEvent.ts

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,47 @@ import { TNSRTCMediaStream } from './TNSRTCMediaStream';
66

77
export class TNSRTCTrackEvent extends TNSRTCTrackEventBase {
88
private _event;
9+
private _mediaTrack: TNSRTCMediaStreamTrack;
10+
private _transceiver: TNSRTCRtpTransceiver;
11+
private _receiver: TNSRTCRtpReceiver;
12+
private _streams: Array<TNSRTCMediaStream>;
913

1014
constructor(event) {
1115
super(event);
1216
this._event = event;
17+
this._mediaTrack = TNSRTCMediaStreamTrack.fromNative(this._event.getMediaTrack());
18+
this._transceiver = this._event.getTransceiver() ? TNSRTCRtpTransceiver.fromNative(this._event.getTransceiver()) : null;
19+
this._receiver = this._event.getReceiver() ? TNSRTCRtpReceiver.fromNative(this._event.getReceiver()) : null;
20+
const array = [];
21+
const nativeArray = this._event.getStreams();
22+
if (nativeArray) {
23+
const size = nativeArray.size();
24+
for (let i = 0; i < size; i++) {
25+
const stream = nativeArray.get(i);
26+
array.push(TNSRTCMediaStream.fromNative(stream));
27+
}
28+
}
29+
this._streams = array;
30+
}
1331

32+
public get track(): TNSRTCMediaStreamTrack {
33+
return this.mediaTrack;
1434
}
1535

1636
public get mediaTrack(): TNSRTCMediaStreamTrack {
17-
return TNSRTCMediaStreamTrack.fromNative(this._event.getMediaTrack());
37+
return this._mediaTrack;
1838
}
1939

2040
public get transceiver(): TNSRTCRtpTransceiver {
21-
return TNSRTCRtpTransceiver.fromNative(this._event.getTransceiver());
41+
return this._transceiver;
2242
}
2343

2444
public get receiver(): TNSRTCRtpReceiver {
25-
return TNSRTCRtpReceiver.fromNative(this._event.getReceiver());
45+
return this._receiver;
2646
}
2747

2848
public get streams(): Array<TNSRTCMediaStream> {
29-
const array = [];
30-
const nativeArray = this._event.getStreams();
31-
const size = nativeArray.size();
32-
for (let i = 0; i < size; i++) {
33-
const stream = nativeArray.get(i);
34-
array.push(TNSRTCMediaStream.fromNative(stream));
35-
}
36-
return array;
37-
49+
return this._streams;
3850
}
3951

4052
public static fromNative(event) {

src/src/base/TNSRTCTrackEventBase.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import { TNSRTCRtpTransceiverBase } from './TNSRTCRtpTransceiverBase';
66
export class TNSRTCTrackEventBase {
77
mediaTrack: TNSRTCMediaStreamTrackBase;
88
transceiver: TNSRTCRtpTransceiverBase;
9-
receiver: TNSRTCRtpReceiverBase;
10-
streams: Array<TNSRTCMediaStreamBase>;
9+
receiver?: TNSRTCRtpReceiverBase;
10+
streams?: Array<TNSRTCMediaStreamBase>;
1111

1212
constructor(event) {
1313
}

src/src/ios/TNSRTCPeerConnection.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -88,63 +88,63 @@ export class TNSRTCPeerConnection {
8888
}
8989

9090
public onConnectionStateChange(callback: () => void): void {
91-
this.ios.onConnectionStateChange = () => {
91+
this.ios.onConnectionStateChange(() => {
9292
callback();
93-
};
93+
});
9494
}
9595

9696
public onTrack(callback: (track: TNSRTCTrackEvent) => void): void {
97-
this.ios.onTrack = (track) => {
97+
this.ios.onTrack(track => {
9898
callback(TNSRTCTrackEvent.fromNative(track));
99-
};
99+
});
100100
}
101101

102102
public onRemoveTrackListener(callback: () => void): void {
103-
this.ios.onRemoveTrack = () => {
103+
this.ios.onRemoveTrack(() => {
104104
callback();
105-
};
105+
});
106106
}
107107

108108
public onRemoveStream(callback: (stream: TNSRTCMediaStream) => void): void {
109-
this.ios.onRemoveStream = (nativeStream) => {
109+
this.ios.onRemoveStream((nativeStream) => {
110110
callback(TNSRTCMediaStream.fromNative(nativeStream));
111-
};
111+
});
112112
}
113113

114114
public onIceGatheringStateChange(callback: any): void {
115-
this.ios.onIceGatheringStateChange = () => {
115+
this.ios.onIceGatheringStateChange(() => {
116116
callback();
117-
};
117+
});
118118
}
119119

120120
public onAddStream(callback: any): void {
121-
this.ios.onAddStream = (nativeStream) => {
121+
this.ios.onAddStream((nativeStream) => {
122122
callback(TNSRTCMediaStream.fromNative(nativeStream));
123-
};
123+
});
124124
}
125125

126126
public onNegotiationNeeded(callback: () => void): void {
127-
this.ios.onNegotiationNeeded = () => {
127+
this.ios.onNegotiationNeeded(() => {
128128
callback();
129-
};
129+
});
130130
}
131131

132132
public onSignalingStateChange(callback: () => void): void {
133-
this.ios.onSignalingStateChange = () => {
133+
this.ios.onSignalingStateChange(() => {
134134
callback();
135-
};
135+
});
136136
}
137137

138138
public onIceCandidate(callback: (candidate: TNSRTCIceCandidate) => void): void {
139-
this.ios.onIceCandidate = (nativeCandidate) => {
139+
this.ios.onIceCandidate((nativeCandidate) => {
140140
callback(TNSRTCIceCandidate.fromNative(nativeCandidate));
141-
};
141+
});
142142
}
143143

144144
public onDataChannel(callback: (channel: TNSRTCDataChannelEvent) => void): any {
145-
this.ios.onDataChannel = (event) => {
145+
this.ios.onDataChannel((event) => {
146146
callback(TNSRTCDataChannelEvent.fromNative(event));
147-
};
147+
});
148148
}
149149

150150

src/src/ios/TNSRTCTrackEvent.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ export class TNSRTCTrackEvent extends TNSRTCTrackEventBase {
1313

1414
}
1515

16+
public get track(): TNSRTCMediaStreamTrack {
17+
return this.mediaTrack;
18+
}
19+
1620
public get mediaTrack(): TNSRTCMediaStreamTrack {
1721
return TNSRTCMediaStreamTrack.fromNative(this._event.mediaTrack);
1822
}
@@ -28,6 +32,7 @@ export class TNSRTCTrackEvent extends TNSRTCTrackEventBase {
2832
public get streams(): Array<TNSRTCMediaStream> {
2933
const array = [];
3034
const nativeArray = this._event.streams;
35+
if (!nativeArray) return array;
3136
const size = nativeArray.count;
3237
for (let i = 0; i < size; i++) {
3338
const stream = nativeArray.objectAtIndex(i);

0 commit comments

Comments
 (0)