Commit 73d09c4
[BACKEND] Set LLVM_ABI_BREAKING_CHECKS to be able to update the llvm version (#4512)
This PR is setting LLVM_ABI_BREAKING_CHECKS=FORCE_OFF, similar of how we
do it inside Google. In this way, we are forcing the structures that
relies in Hashing.h to use a deterministic seed.
We were not able to update the llvm version. The culprit llvm commit is
llvm/llvm-project@ce80c80,
that basically uses a non-deterministic seed if the previous "Flag" is
set.
There were some discussions in
#4338, and the other option
would be to check/replace code and tests that are overly depending on
the determinism of llvm/include/llvm/ADT/Hashing.h (DenseMap and
DenseSet mostly).
I think that the priority is first to be able to update the llvm
version, but if OpenAI is interested I could work on replacing them (for
MapVector), in order to fix all the failing unit tests, and then we can
set the LLVM_ABI_BREAKING_CHECKS again to "WITH_ASSERTS".
- [x] I am not making a trivial change, such as fixing a typo in a
comment.
- [x] I have written a PR description following these
[rules](https://cbea.ms/git-commit/#why-not-how).
- [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`.
- [x] This PR does not need a test because it's just setting a variable
for LLVM.
- [x] I have not added any `lit` tests.
Co-authored-by: Tori Baker <[email protected]>1 parent 45af9a9 commit 73d09c4
File tree
3 files changed
+6
-1
lines changed- .github/workflows
- llvm-build
- cmake
3 files changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| |||
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
| 134 | + | |
133 | 135 | | |
134 | 136 | | |
135 | 137 | | |
| |||
175 | 177 | | |
176 | 178 | | |
177 | 179 | | |
| 180 | + | |
178 | 181 | | |
179 | 182 | | |
180 | 183 | | |
| |||
225 | 228 | | |
226 | 229 | | |
227 | 230 | | |
| 231 | + | |
228 | 232 | | |
229 | 233 | | |
230 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments