detection of Move and Rename Method in PR

tsantalis · tsantalis · commit 2ae194c93f8d · 2024-05-18T05:27:51.000-04:00
JabRef/jabref#8934 #715
diff --git a/src/main/java/gr/uom/java/xmi/diff/UMLModelDiff.java b/src/main/java/gr/uom/java/xmi/diff/UMLModelDiff.java
@@ -4684,7 +4684,10 @@ private boolean movedAndRenamedMethodSignature(UMLOperation removedOperation, UM
 			}
 		}
 		double normalizedEditDistance = mapper.normalizedEditDistance();
-		if(exactLeafMappings == 0 && normalizedEditDistance > 0.24) {
+		boolean zeroNonMapped = mapper.getNonMappedLeavesT1().size() == 0 && mapper.getNonMappedLeavesT2().size() == 0 &&
+				mapper.getNonMappedInnerNodesT1().size() == 0 && mapper.getNonMappedInnerNodesT2().size() == 0 &&
+				removedOperation.hasTestAnnotation() && addedOperation.hasTestAnnotation();
+		if(exactLeafMappings == 0 && !zeroNonMapped && normalizedEditDistance > 0.24) {
 			return false;
 		}
 		if(exactLeafMappings == 1 && normalizedEditDistance > 0.51 && (mapper.nonMappedElementsT1() > 0 || mapper.nonMappedElementsT2() > 0)) {

Original file line number	Diff line number	Diff line change
`@@ -4684,7 +4684,10 @@ private boolean movedAndRenamedMethodSignature(UMLOperation removedOperation, UM`
`4684`	`4684`	`}`
`4685`	`4685`	`}`
`4686`	`4686`	`double normalizedEditDistance = mapper.normalizedEditDistance();`
`4687`		`- if(exactLeafMappings == 0 && normalizedEditDistance > 0.24) {`
	`4687`	`+ boolean zeroNonMapped = mapper.getNonMappedLeavesT1().size() == 0 && mapper.getNonMappedLeavesT2().size() == 0 &&`
	`4688`	`+ mapper.getNonMappedInnerNodesT1().size() == 0 && mapper.getNonMappedInnerNodesT2().size() == 0 &&`
	`4689`	`+ removedOperation.hasTestAnnotation() && addedOperation.hasTestAnnotation();`
	`4690`	`+ if(exactLeafMappings == 0 && !zeroNonMapped && normalizedEditDistance > 0.24) {`
`4688`	`4691`	`return false;`
`4689`	`4692`	`}`
`4690`	`4693`	`if(exactLeafMappings == 1 && normalizedEditDistance > 0.51 && (mapper.nonMappedElementsT1() > 0 \|\| mapper.nonMappedElementsT2() > 0)) {`