Create test/window directory and conftest file #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 8, 2019
Collaborator
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
I would do this versus pandas/master. Best to push whatever we can there in small uncontroversial bits.
|
|
||
| @pytest.fixture( | ||
| params=["sum", "mean", "median", "max", "min", "var", "std", "kurt", "skew"] | ||
| ) |
Collaborator
There was a problem hiding this comment.
can you add a 1-line comment on each of these
Collaborator
Author
|
Sounds good. I'll open this PR up against pandas/master instead. |
Collaborator
Author
|
Created pandas-dev#27305 with the first cleanup |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #2