fix(eslint-plugin): [no-useless-constructor] handle parameter decorator (#5450)

* fix(eslint-plugin): [no-useless-constructor] handle parameter decorator

* Update packages/eslint-plugin/src/rules/no-useless-constructor.ts

Co-authored-by: Josh Goldberg <[email protected]>

Author: yeonjuan

packages/eslint-plugin/src/rules/no-useless-constructor.ts

@@ -31,13 +31,15 @@ function checkAccessibility(node: TSESTree.MethodDefinition): boolean {
 }
 
 /**
- * Check if method is not unless due to typescript parameter properties
+ * Check if method is not useless due to typescript parameter properties and decorators
  */
 function checkParams(node: TSESTree.MethodDefinition): boolean {
   return (
     !node.value.params ||
     !node.value.params.some(
-      param => param.type === AST_NODE_TYPES.TSParameterProperty,
+      param =>
+        param.type === AST_NODE_TYPES.TSParameterProperty ||
+        param.decorators?.length,
     )
   );
 }

packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts

@@ -206,6 +206,20 @@ class A extends B {
     `
 class A {
   constructor(foo);
+}
+    `,
+    `
+class A extends Object {
+  constructor(@Foo foo: string) {
+    super(foo);
+  }
+}
+    `,
+    `
+class A extends Object {
+  constructor(foo: string, @Bar() bar) {
+    super(foo, bar);
+  }
 }
     `,
   ],