Skip to content

Commit 2cd7c6a

Browse files
committed
Fix job names so they can be selected as required statuses
Usually there are not many jobs and they don't overlap so their naming is easy. In this case I forgot that statuses are per-job not per file or anything, so - the naming overlap between the "normal" python tests and the release made knowing which was which much harder than necessary - the rust and python checks literally having the same job name made one of them (not sure which) impossible to select - having all the rust stuff as a single "checks" jobs didn't help either, split it into checks and tests to more or less mirror the python stuff - prefix jobs with their language as it's not out the question that the repository would grow e.g. JS bindings in neon, or a C API for FFI, or whatever, and those would need to be clearly identified
1 parent 520680e commit 2cd7c6a

File tree

4 files changed

+22
-15
lines changed

4 files changed

+22
-15
lines changed

.github/workflows/pychecks.yaml renamed to .github/workflows/py-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ permissions:
88
contents: read
99

1010
jobs:
11-
checks:
11+
py-checks:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- name: Checkout working copy

.github/workflows/py-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ permissions:
88
contents: read
99

1010
jobs:
11-
wheels:
11+
py-test-wheels:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
@@ -53,8 +53,8 @@ jobs:
5353
retention-days: 1
5454
compression-level: 0
5555

56-
tests:
57-
needs: wheels
56+
py-tests:
57+
needs: py-test-wheels
5858
runs-on: ubuntu-latest
5959
strategy:
6060
fail-fast: false

.github/workflows/pyo3-wheels.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ permissions:
1313
contents: read
1414

1515
jobs:
16-
wheels:
16+
py-release-wheels:
1717
strategy:
1818
matrix:
1919
python-version:
@@ -75,7 +75,7 @@ jobs:
7575
retention-days: 1
7676
compression-level: 0
7777

78-
sdist:
78+
py-release-sdist:
7979
runs-on: ubuntu-latest
8080
steps:
8181
- uses: actions/checkout@v4
@@ -90,8 +90,8 @@ jobs:
9090
name: wheels-sdist
9191
path: dist
9292

93-
tests:
94-
needs: wheels
93+
py-release-tests:
94+
needs: py-release-wheels
9595

9696
strategy:
9797
matrix:
@@ -168,10 +168,10 @@ jobs:
168168
- name: Run tests
169169
run: pytest -v -Werror -ra ua-parser-py
170170

171-
release:
171+
py-release:
172172
name: Release
173173
runs-on: ubuntu-latest
174-
needs: [tests, sdist]
174+
needs: [py-release-tests, py-release-sdist]
175175
if: ${{ inputs.release == 'true' }}
176176
permissions:
177177
# Use to sign the release artifacts

.github/workflows/rust.yml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,25 @@ env:
88
CARGO_TERM_COLOR: always
99

1010
jobs:
11-
checks:
11+
rust-checks:
1212
runs-on: ubuntu-latest
1313

1414
steps:
1515
- uses: actions/checkout@v4
16-
with:
17-
submodules: true
18-
- name: Check
19-
run: cargo check
2016
- name: Format
2117
run: cargo fmt --check
2218
- name: clippy
19+
if: always()
2320
run: cargo clippy
21+
22+
rust-tests:
23+
runs-on: ubuntu-latest
24+
25+
steps:
26+
- uses: actions/checkout@v4
27+
with:
28+
submodules: true
29+
- name: Check
30+
run: cargo check
2431
- name: Run tests
2532
run: cargo test -r --verbose

0 commit comments

Comments
 (0)