Adding Playwright Tests

[ryanrath]

Description

Motivation and Context

Tests performed

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project as found in the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jpwhite4]

Why change the path?

[jpwhite4]

Nothing inside the docker container needs this environment variable. Please don't add it

[jpwhite4]

Please don't hardcode paths in this file. They should be defined once in the top level .circleci/config.yml (in fact they are defined there already).

Also this is not needed inside the docker container so you don't need to add it.

[jpwhite4]

MODULE_INSTALL_DIR that is...

[jpwhite4]

How come the playwright/test dependency is listed here? The supremm tests won't work with this dependency - they need the xdmod base tests to function.

[jpwhite4]

Suggested change

	command: docker cp xdmod:/root/xdmod/tests/playwright/test-results/. ~/project/log/playwright/xdmod
	command: docker cp playwright:$XDMOD_INSTALL_DIR/tests/playwright/test-results/. ~/project/log/playwright/xdmod

[jpwhite4]

Seen this message in the logs:

***************************************************************
Shared memory is less than 2G, tests may fail randomly
If you are using Docker use the option of --shm-size 2g
***************************************************************

is this a concern?