Skip to content

feat(nativeelementhosting): Z-order support #21638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

feat(nativeelementhosting): Z-order support #21638

wants to merge 16 commits into from
+320 −223

Conversation

@ramezgerges
Copy link
Contributor

GitHub Issue: closes #21376

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

Other information ℹ️

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation platform/wpf 🪟 Categorizes an issue or PR as relevant to WPF platform/x11 🐧 Categorizes an issue or PR as relevant to X11 labels Oct 19, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 178955 has failed on Uno.UI - CI.

@MartinZikmund
Copy link
Member

@ramezgerges Does this mean if there are two native elements on top of each other are technically still there, even if the bottom one is Collapsed? I'm thinking whether that could still pose problems, for example if the one on top would not be fully opaque - then the one underneath would still be visible to the user, even though it should be Collapsed.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@ramezgerges ramezgerges force-pushed the webview_zindex_visibility branch from 39e4a26 to 12da927 Compare October 20, 2025 14:25
@ramezgerges
Copy link
Contributor Author

@MartinZikmund Indeed. This complicates the lifecycle a little bit (at least until https://github.com/unoplatform/uno-private/issues/742), but I've adjusted the changes to completely remove out-of-view native elements.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@ramezgerges ramezgerges force-pushed the webview_zindex_visibility branch from 5454e16 to fcf28de Compare October 20, 2025 18:34
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 179068 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 179217 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21638/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21638/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 180387 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spouliot spouliot spouliot left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees

No one assigned

Labels

area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/wpf 🪟 Categorizes an issue or PR as relevant to WPF platform/x11 🐧 Categorizes an issue or PR as relevant to X11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WebView2] [Desktop/Wasm] WebView2.Visibility is not working as expected

5 participants

@ramezgerges @unodevops @MartinZikmund @spouliot @Xiaoy312