Skip to content

Commit 103e862

Browse files
author
Release Manager
committed
sagemathgh-35404: Drop support for Python 3.8 <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description In preparation for important package upgrades, we remove support for Python v3.8. (Almost) all occurrences of "Python 3.8" are removed from the codebase. There are still some comments left that essentially say that in newer versions things can be simplified, but I didn't touch those and leave them for follow-up PRs. This will help with: - PRs that require Python 3.9 or above, such as sagemath#34973 and sagemath#35188. - Upgrades of Python packages that have dropped support for Python 3.8 because they follow NEP 29 and have already released a new major version that drops support according to the NEP 29 schedule. - NetworkX 3.2 (expected 2023-??; version 3.1 was released 2023-04, see sagemath#35671) - sagemath#34816 - sagemath#35703 - See also sagemath#32074. Test run: https://github.com/tobiasdiez/sage/actions/runs/4586981626 <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35404 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Matthias Köppe
2 parents 2d10476 + 11c2a87 commit 103e862

File tree

38 files changed

+29
-95
lines changed

38 files changed

+29
-95
lines changed

.github/workflows/dist.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ jobs:
100100
#
101101
CIBW_ARCHS: ${{ matrix.arch }}
102102
# https://cibuildwheel.readthedocs.io/en/stable/options/#requires-python
103-
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8"
103+
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9"
104104
# Environment during wheel build
105105
CIBW_ENVIRONMENT: "PATH=$(pwd)/local/bin:$PATH CPATH=$(pwd)/local/include:$CPATH LIBRARY_PATH=$(pwd)/local/lib:$LIBRARY_PATH PKG_CONFIG_PATH=$(pwd)/local/share/pkgconfig:$PKG_CONFIG_PATH ACLOCAL_PATH=/usr/share/aclocal"
106106
# Use 'build', not 'pip wheel'

.github/workflows/docker.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ on:
1818
default: >-
1919
["ubuntu-trusty-toolchain-gcc_9",
2020
"ubuntu-xenial-toolchain-gcc_9",
21-
"ubuntu-bionic-gcc_8-python3.8",
2221
"ubuntu-focal",
2322
"ubuntu-jammy",
2423
"ubuntu-kinetic",
@@ -28,16 +27,13 @@ on:
2827
"debian-bullseye",
2928
"debian-bookworm",
3029
"debian-sid",
31-
"linuxmint-19-gcc_8-python3.8",
32-
"linuxmint-19.3-gcc_8-python3.8",
3330
"linuxmint-20.1",
3431
"linuxmint-20.2",
3532
"linuxmint-20.3",
3633
"linuxmint-21",
3734
"linuxmint-21.1",
3835
"linuxmint-21.2",
39-
"fedora-29-python3.8",
40-
"fedora-30-python3.8",
36+
"fedora-30",
4137
"fedora-31",
4238
"fedora-32",
4339
"fedora-33",

.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Set up Python
1818
uses: actions/setup-python@v4
1919
with:
20-
python-version: 3.8
20+
python-version: 3.9
2121
- name: Install pycodestyle
2222
run: pip install tox pycodestyle
2323
- name: Lint using pycodestyle
@@ -31,7 +31,7 @@ jobs:
3131
- name: Set up Python
3232
uses: actions/setup-python@v4
3333
with:
34-
python-version: 3.8
34+
python-version: 3.9
3535
- name: Install relint
3636
run: pip install tox relint
3737
- name: Lint using relint
@@ -45,7 +45,7 @@ jobs:
4545
- name: Set up Python
4646
uses: actions/setup-python@v4
4747
with:
48-
python-version: 3.8
48+
python-version: 3.9
4949
- name: Install tox
5050
run: pip install tox
5151
- name: Lint using tox -e rst

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ in the Installation Guide.
201201
more details.
202202

203203
- Python 3.4 or later, or Python 2.7, a full installation including
204-
`urllib`; but ideally version 3.8.x, 3.9.x, or 3.10.x, which
204+
`urllib`; but ideally version 3.9.x, 3.10.x, or 3.11.x, which
205205
will avoid having to build Sage's own copy of Python 3.
206206
See [build/pkgs/python3/SPKG.rst](build/pkgs/python3/SPKG.rst)
207207
for more details.

build/pkgs/_python3.8/distros/arch.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

build/pkgs/_python3.8/distros/cygwin.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

build/pkgs/_python3.8/distros/debian.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

build/pkgs/_python3.8/distros/fedora.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

build/pkgs/_python3.8/distros/freebsd.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

build/pkgs/_python3.8/distros/homebrew.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)