add new test case for parallel routes

huozhi · huozhi · commit 3d948d02592c · 2025-04-14T11:46:02.000+02:00
diff --git a/packages/next/src/client/components/router-reducer/reducers/find-head-in-cache.ts b/packages/next/src/client/components/router-reducer/reducers/find-head-in-cache.ts
@@ -1,5 +1,6 @@
 import type { FlightRouterState } from '../../../../server/app-render/types'
 import type { CacheNode } from '../../../../shared/lib/app-router-context.shared-runtime'
+import { DEFAULT_SEGMENT_KEY } from '../../../../shared/lib/segment'
 import { createRouterCacheKey } from '../create-router-cache-key'
 
 export function findHeadInCache(
@@ -34,6 +35,11 @@ function findHeadInCacheImpl(
   // if we didn't find metadata in the page slot, check the other parallel routes
   for (const key of parallelRoutesKeys) {
     const [segment, childParallelRoutes] = parallelRoutes[key]
+    // If the parallel is not matched and using the default segment,
+    // skip searching the head from it.
+    if (segment === DEFAULT_SEGMENT_KEY) {
+      continue
+    }
     const childSegmentMap = cache.parallelRoutes.get(key)
     if (!childSegmentMap) {
       continue
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/layout.tsx
@@ -0,0 +1,27 @@
+import Link from 'next/link'
+import { ReactNode } from 'react'
+
+export default function Root({ children }: { children: ReactNode }) {
+  return (
+    <html>
+      <body>
+        <div>
+          <Link href="/parallel-routes" id="to-parallel-routes">
+            {`to /parallel-routes`}
+          </Link>
+          <br />
+          <Link href="/parallel-routes-default" id="to-default">
+            {`to /parallel-routes-default`}
+          </Link>
+          <br />
+
+          <Link href="/parallel-routes-no-children" id="to-no-children">
+            {`to /parallel-routes-no-children`}
+          </Link>
+          <br />
+        </div>
+        {children}
+      </body>
+    </html>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/page.tsx
@@ -0,0 +1,12 @@
+export default function Page() {
+  return <p>index page</p>
+}
+
+export async function generateMetadata() {
+  await new Promise((resolve) => setTimeout(resolve, 1 * 1000))
+  return {
+    title: 'index page',
+  }
+}
+
+export const dynamic = 'force-dynamic'
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@bar Layout</h2>
+      <div id="bar-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@bar/test-page/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'test-page @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@foo Layout</h2>
+      <div id="foo-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/no-bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/no-bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'no-bar @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/@foo/test-page/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'test-page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default no-children'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/layout.tsx
@@ -0,0 +1,22 @@
+import { connection } from 'next/server'
+
+export default function Layout({ bar, foo, children }) {
+  return (
+    <div>
+      <h1>Parallel Routes Layout - No Children</h1>
+      <div id="foo-slot">{foo}</div>
+      <div id="bar-slot">{bar}</div>
+
+      {/* hitting default.js */}
+      {children}
+    </div>
+  )
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 300))
+  return {
+    title: 'parallel-routes-default layout title',
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/no-bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/no-bar/page.tsx
@@ -0,0 +1,13 @@
+import { connection } from 'next/server'
+
+export default function TestPage() {
+  return 'test page'
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 3000))
+  return {
+    title: `Dynamic api ${Math.random()}`,
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-default/test-page/page.tsx
@@ -0,0 +1,13 @@
+import { connection } from 'next/server'
+
+export default function TestPage() {
+  return 'test page'
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 1000))
+  return {
+    title: `Dynamic api ${Math.random()}`,
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/first/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/first/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <p id="bar-page">test-page @bar - 1</p>
+}
+
+export const metadata = {
+  title: 'first page - @bar',
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@bar Layout</h2>
+      <div id="bar-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/second/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@bar/second/page.tsx
@@ -0,0 +1,7 @@
+export default function Page() {
+  return <p id="bar-page">test-page @bar - 2</p>
+}
+
+export const metadata = {
+  title: 'second page - @bar',
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@foo Layout</h2>
+      <div id="foo-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/no-bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/no-bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'no-bar @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/@foo/test-page/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'test-page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes-no-children/layout.tsx
@@ -0,0 +1,34 @@
+import { connection } from 'next/server'
+import Link from 'next/link'
+
+// skip rendering children
+export default function Layout({ bar, foo }) {
+  return (
+    <div>
+      <h1>Parallel Routes Layout - No Children</h1>
+
+      <Link href="/parallel-routes-no-children/first" id="to-no-children-first">
+        {`to /parallel-routes-no-children/first`}
+      </Link>
+      <br />
+      <Link
+        href="/parallel-routes-no-children/second"
+        id="to-no-children-second"
+      >
+        {`to /parallel-routes-no-children/second`}
+      </Link>
+      <br />
+
+      <div id="foo-slot">{foo}</div>
+      <div id="bar-slot">{bar}</div>
+    </div>
+  )
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 300))
+  return {
+    title: 'parallel-routes-default layout title',
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@bar Layout</h2>
+      <div id="bar-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@bar/test-page/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'test-page @bar'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/default.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/default.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'default @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/layout.tsx
@@ -0,0 +1,8 @@
+export default function Layout({ children }) {
+  return (
+    <div>
+      <h2>@foo Layout</h2>
+      <div id="foo-children">{children}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/no-bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/no-bar/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'no-bar @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/@foo/test-page/page.tsx
@@ -0,0 +1,3 @@
+export default function Page() {
+  return 'test-page @foo'
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/layout.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/layout.tsx
@@ -0,0 +1,10 @@
+export default function Layout({ children, bar, foo }) {
+  return (
+    <div>
+      <h1>Parallel Routes Layout</h1>
+      <div id="nested-children">{children}</div>
+      <div id="foo-slot">{foo}</div>
+      <div id="bar-slot">{bar}</div>
+    </div>
+  )
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/no-bar/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/no-bar/page.tsx
@@ -0,0 +1,20 @@
+import Link from 'next/link'
+import { connection } from 'next/server'
+
+export default function Page() {
+  return (
+    <div>
+      <p>no bar</p>
+      <Link href="/parallel-routes">Back to /parallel-routes</Link>
+    </div>
+  )
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 1000))
+  return {
+    title: `Dynamic api ${Math.random()}`,
+    description: 'no-bar description',
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/page.tsx
@@ -0,0 +1,19 @@
+import Link from 'next/link'
+
+export default function Page() {
+  return (
+    <div>
+      Hello from Nested <br />
+      <Link href="/parallel-routes/test-page">
+        To /parallel-routes/test-page
+      </Link>
+      <br />
+      <Link href="/parallel-routes/no-bar">To /parallel-routes/no-bar</Link>
+    </div>
+  )
+}
+
+export const metadata = {
+  title: 'parallel title',
+  description: 'parallel description',
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/test-page/page.tsx b/test/e2e/app-dir/metadata-streaming-parallel-routes/app/parallel-routes/test-page/page.tsx
@@ -0,0 +1,13 @@
+import { connection } from 'next/server'
+
+export default function TestPage() {
+  return 'test page'
+}
+
+export async function generateMetadata() {
+  await connection()
+  await new Promise((resolve) => setTimeout(resolve, 1000))
+  return {
+    title: `Dynamic api ${Math.random()}`,
+  }
+}
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/metadata-streaming-parallel-routes.test.ts b/test/e2e/app-dir/metadata-streaming-parallel-routes/metadata-streaming-parallel-routes.test.ts
diff --git a/test/e2e/app-dir/metadata-streaming-parallel-routes/next.config.js b/test/e2e/app-dir/metadata-streaming-parallel-routes/next.config.js
diff --git a/test/e2e/app-dir/metadata-streaming/metadata-streaming.test.ts b/test/e2e/app-dir/metadata-streaming/metadata-streaming.test.ts

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function Page() {`
	`2`	`+ return 'default @bar'`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function Page() {`
	`2`	`+ return 'page @bar'`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function Page() {`
	`2`	`+ return 'test-page @bar'`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function Page() {`
	`2`	`+ return 'default @foo'`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function Page() {`
	`2`	`+ return 'no-bar @foo'`
	`3`	`+}`