Skip to content

Commit 4059eb0

Browse files
committed
add comment
1 parent 0b843ba commit 4059eb0

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ createNextDescribe(
1010
({ next }) => {
1111
// experimental react is having issues with this use effect
1212
// @acdlite will take a look
13+
// TODO: remove this after react fixes the issue in experimental build.
1314
if (process.env.__NEXT_EXPERIMENTAL_PPR) {
1415
it('skip test for PPR', () => {})
1516
return

test/e2e/app-dir/navigation/navigation.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ createNextDescribe(
77
{
88
files: __dirname,
99
},
10-
({ next, isNextDev, isNextDeploy, isNextStart }) => {
10+
({ next, isNextDev, isNextDeploy }) => {
1111
describe('query string', () => {
1212
it('should set query correctly', async () => {
1313
const browser = await next.browser('/')
@@ -81,7 +81,12 @@ createNextDescribe(
8181
pathname: '/search-params/foo',
8282
// App Router doesn't re-render on initial load (the params are baked
8383
// server side). In development, effects will render twice.
84-
waitForNEffects: isNextDev ? 2 : 1,
84+
85+
// experimental react is having issues with this use effect
86+
// @acdlite will take a look
87+
// TODO: remove this PPR cond after react fixes the issue in experimental build.
88+
waitForNEffects:
89+
isNextDev && !process.env.__NEXT_EXPERIMENTAL_PPR ? 2 : 1,
8590
},
8691
{
8792
router: 'pages',

0 commit comments

Comments
 (0)