Skip to content

Commit bc66f55

Browse files
authored
Remove unsafeCache from benchmark + use cross-env for benchmark (#29425)
Fixes from @sokra's review of #29325 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
1 parent ace8963 commit bc66f55

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

bench/nested-deps/next.config.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ module.exports = {
22
eslint: {
33
ignoreDuringBuilds: true,
44
},
5-
webpack(config) {
6-
config.module.unsafeCache = true
7-
return config
8-
},
95
experimental: {
106
swcLoader: true,
117
swcMinify: true,

bench/nested-deps/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"scripts": {
33
"prepare": "rm -rf components && mkdir components && node ./fuzzponent.js -d 2 -s 206 -o components",
4-
"dev": "NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next dev",
5-
"build": "NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next build",
6-
"start": "NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next start",
4+
"dev": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next dev",
5+
"build": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next build",
6+
"start": "cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 ../../node_modules/.bin/next start",
77
"dev-nocache": "rm -rf .next && yarn dev",
8-
"dev-cpuprofile-nocache": "rm -rf .next && NEXT_PRIVATE_LOCAL_WEBPACK5=1 node --cpu-prof ../../node_modules/.bin/next",
8+
"dev-cpuprofile-nocache": "rm -rf .next && cross-env NEXT_PRIVATE_LOCAL_WEBPACK5=1 node --cpu-prof ../../node_modules/.bin/next",
99
"build-nocache": "rm -rf .next && yarn build"
1010
}
1111
}

0 commit comments

Comments
 (0)