Remove Old Prerender Implementation #8218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
added a commit
to ijjk/next.js
that referenced
this pull request
Aug 2, 2019
This reverts commit 2ab300d.
ijjk
added a commit
that referenced
this pull request
Aug 6, 2019
* Revert "Remove Old Prerender Implementation (#8218)" This reverts commit 2ab300d. * Add contentHandler for page config * Rename config from contentHandler to re-use experimentalPrerender * Remove un-needed changes * Replace backslashes for manifest * Update manifest output format * Make prerender: true enable SPR behavior and update to merge prerender-manifest for flying-shuttle * Fix output path for / prerender file * Add dynamic routes to test suite * Add generating and previewing of skeletons for prerendered dynamic routes * remove inline prerender option * update to not replace getInitialProps which allows nested getInitialProps and add query when fetching prerender * Apply suggestions from code review Co-Authored-By: Joe Haddad <[email protected]> * Remove legacy prerender option * Apply suggestions from review * Apply more suggestions from review * Apply suggestions from code review Co-Authored-By: Joe Haddad <[email protected]> * Add handling of error when parsing json * Update handling of moving exported pages * Rename nextPreviewSkeleton to _nextPreviewSkeleton * bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old prerender implementation added in #7699.
Motivation for this PR: It's really hard to review #7983 without looking at the actual changes, since it's completely replacing this one.
It'd be better to remove the old one and rebase that PR on top of this removal.