Skip to content

Commit 28d7691

Browse files
authored
[FOLLOWUP][Misc] Remove unused mypy config for base_communicator (#45)
### What this PR does / why we need it? - Remove on communicator mypy to address: #24 (comment) - Add mypy.ini to trigger list ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
1 parent 86796cf commit 28d7691

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/mypy.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ on:
2727
- '**/*.py'
2828
- '.github/workflows/mypy.yaml'
2929
- 'tools/mypy.sh'
30+
- 'mypy.ini'
3031
pull_request:
3132
branches:
3233
- "main"
@@ -39,6 +40,7 @@ on:
3940
- '**/*.py'
4041
- '.github/workflows/mypy.yaml'
4142
- 'tools/mypy.sh'
43+
- 'mypy.ini'
4244

4345
jobs:
4446
mypy:

mypy.ini

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,3 @@ ignore_missing_imports = True
99
[mypy-transformers.*]
1010
ignore_missing_imports = True
1111

12-
; Remove this after https://github.com/vllm-project/vllm/pull/11324 merged
13-
[mypy-vllm.distributed.device_communicators.base_communicator]
14-
ignore_missing_imports = True

0 commit comments

Comments
 (0)