Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
VLLM_MLA_PERFORM_MATRIX_ABSORPTION=0for fp8 by just up converting to fp16, also switch to using bmm from einsum to make it more obvious the kernels needed / easier to integrate an fp8 bmm (we would need block-scale support for 64x128, or 128x64, I need to work through it)Based on these calculations (may be bugged): https://docs.google.com/spreadsheets/d/17eoqEbhblvtNsRRlFSjCQnEXZiBxtLgZGKD4IgZUz38/edit?usp=sharing
VLLM_MLA_PERFORM_MATRIX_ABSORPTION=0should introduce 143% memory overheadwhile:
VLLM_MLA_PERFORM_MATRIX_ABSORPTION=1(default) should introduce 318% memory overheadwe will likely want to make
VLLM_MLA_PERFORM_MATRIX_ABSORPTION=0the defaultwith
VLLM_MLA_PERFORM_MATRIX_ABSORPTION=0: