From 1a76529b13c843c8187dd997471afdda8ca2f355 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Thu, 20 Mar 2025 10:48:29 -0400 Subject: [PATCH] [Build/CI] Add tracing deps to vllm container image A report requested that these dependencies be included in the image for tracing. That seems reasonable - they are needed by `vllm.tracing`. Stop manually installing them in the relevant test pipeline and just include them in the image. Signed-off-by: Russell Bryant --- .buildkite/test-pipeline.yaml | 5 ----- requirements/common.txt | 4 ++++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml index 9ef498f86eca..f091d191c6e9 100644 --- a/.buildkite/test-pipeline.yaml +++ b/.buildkite/test-pipeline.yaml @@ -163,11 +163,6 @@ steps: - tests/tracing commands: - pytest -v -s metrics - - "pip install \ - 'opentelemetry-sdk>=1.26.0,<1.27.0' \ - 'opentelemetry-api>=1.26.0,<1.27.0' \ - 'opentelemetry-exporter-otlp>=1.26.0,<1.27.0' \ - 'opentelemetry-semantic-conventions-ai>=0.4.1,<0.5.0'" - pytest -v -s tracing ##### fast check tests ##### diff --git a/requirements/common.txt b/requirements/common.txt index bb1bb2dd994e..32745a101f65 100644 --- a/requirements/common.txt +++ b/requirements/common.txt @@ -43,3 +43,7 @@ watchfiles # required for http server to monitor the updates of TLS files python-json-logger # Used by logging as per examples/other/logging_configuration.md scipy # Required for phi-4-multimodal-instruct ninja # Required for xgrammar, rocm, tpu, xpu +opentelemetry-sdk>=1.26.0,<1.27.0 # vllm.tracing +opentelemetry-api>=1.26.0,<1.27.0 # vllm.tracing +opentelemetry-exporter-otlp>=1.26.0,<1.27.0 # vllm.tracing +opentelemetry-semantic-conventions-ai>=0.4.1,<0.5.0 # vllm.tracing