Skip to content

Conversation

@russellb
Copy link
Member

@russellb russellb commented Apr 25, 2025

This reverts commit 47bdee4 from #17026.

This PR introduced a requirements file pinning versions of vllm and
dependencies to ones that have known security vulnerabilties. This set
off a bunch of warnings in my security dashboard for vllm. We should not
have any recommendations for installing vulnerable versions, so I
suggest this be reverted.

Signed-off-by: Russell Bryant [email protected]

This reverts commit 47bdee4.

This PR introduced a requirements file pinning versions of vllm and
dependencies to ones that have known security vulnerabilties. This set
off a bunch of warnings in my security dashboard for vllm. We should not
have any recommendations for installing vulnerable versions, so I
suggest this be reverted.

Signed-off-by: Russell Bryant <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Apr 25, 2025
@russellb russellb mentioned this pull request Apr 25, 2025
@russellb russellb requested a review from DarkLight1337 April 25, 2025 14:16
@russellb russellb added the security Security related issues and PRs label Apr 25, 2025
@russellb
Copy link
Member Author

closed in favor of #17190 17190

@russellb russellb closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation security Security related issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant