Skip to content

Conversation

@bwasti
Copy link
Contributor

@bwasti bwasti commented Oct 7, 2025

This change reinstates already approved + landed #25769 based on the latest bump to flashinfer:

#26326

It should not land before #26326

Signed-off-by: Bram Wasti <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reinstates support for batch invariant kernel overrides for the FlashInfer backend, which is a crucial feature for ensuring deterministic outputs regardless of batch composition. The changes primarily involve updating the FlashInfer dependency and plumbing through new parameters to enable a deterministic mode in the backend. Additionally, the batch invariance tests have been significantly improved to be more robust, configurable, and to cover the FlashInfer backend. My review focuses on the correctness and robustness of these changes. The implementation for enabling batch invariance in FlashInfer appears solid. I've identified a couple of minor issues in the updated test file where a hardcoded value should be replaced with a configurable variable to make the test more robust. Overall, the changes are well-implemented and the test enhancements are excellent.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pre-commit issue so that we can get this landed

@mergify
Copy link

mergify bot commented Oct 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @bwasti.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 9, 2025
@mergify mergify bot removed the needs-rebase label Oct 10, 2025
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 10, 2025
@yewentao256 yewentao256 merged commit 3263799 into vllm-project:main Oct 13, 2025
86 checks passed
1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Dhruvil Bhatt <[email protected]>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: bbartels <[email protected]>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
… [2/n] (vllm-project#26373)

Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

Development

Successfully merging this pull request may close these issues.

2 participants