-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Model] Adding Granite model. #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
|
Thanks @shawntan! Could you rebase on the latest main branch, and add a test in https://github.com/vllm-project/vllm/tree/main/tests/models similar to the other model architectures? |
b79bb1d to
19d622f
Compare
|
@shawntan to avoid duplication / maintenance overhead would it make more sense to just add the optional multipliers to |
|
@njhill HF PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shawntan, looks great.
However, we may need to keep the config class here for the time being, until a new transformers version is released containing it and vLLM moves to that version. Could you reinstate that?
And take it out of draft if it's now ready to be merged?
- Removed granite config. - Updated test with offiicial model
Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Alvant <[email protected]>
Co-authored-by: Nick Hill <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>
Adds Granite model class to vLLM.
Model will be on Hugging Face once huggingface/transformers#31502 is merged.