Implement Ref copy constructor

Author: BastiaanOlij

include/godot_cpp/classes/ref.hpp

@@ -120,19 +120,31 @@ class Ref {
 
 	template <class T_Other>
 	void operator=(const Ref<T_Other> &p_from) {
+		/* Object::cast_to<T> does not work reliably, see: https://github.com/godotengine/godot-cpp/issues/610
 		RefCounted *refb = const_cast<RefCounted *>(static_cast<const RefCounted *>(p_from.ptr()));
 		if (!refb) {
 			unref();
 			return;
 		}
+
 		Ref r;
 		r.reference = Object::cast_to<T>(refb);
 		ref(r);
 		r.reference = nullptr;
+		*/
+
+		// Let C++ do the casting, more limited but will give a compiler error for incompatible casts...
+		Ref r;
+		r.reference = const_cast<T *>(static_cast<const T *>(p_from.ptr()));
+		ref(r);
+		r.reference = nullptr;
 	}
 
 	void operator=(const Variant &p_variant) {
 		// FIXME
+		// Object::cast_to<T> does not work reliably, see: https://github.com/godotengine/godot-cpp/issues/610
+		// As variant stores our Godot pointer (_owner) we can't reliably cast here until we fix the above mentioned issue
+
 		// Object *object = p_variant.get_validated_object();
 
 		// if (object == reference) {
@@ -168,6 +180,28 @@ class Ref {
 		ref(p_from);
 	}
 
+	template <class T_Other>
+	Ref(const Ref<T_Other> &p_from) {
+		/* Object::cast_to<T> does not work reliably, see: https://github.com/godotengine/godot-cpp/issues/610
+		RefCounted *refb = const_cast<RefCounted *>(static_cast<const RefCounted *>(p_from.ptr()));
+		if (!refb) {
+			unref();
+			return;
+		}
+
+		Ref r;
+		r.reference = Object::cast_to<T>(refb);
+		ref(r);
+		r.reference = nullptr;
+		*/
+
+		// cast to the type we contain
+		reference = const_cast<T *>(static_cast<const T *>(p_from.ptr()));
+		if (reference) { // pretty sure we would get a compiler error if not applicable...
+			reference->reference();
+		}
+	}
+
 	Ref(T *p_reference) {
 		if (p_reference) {
 			ref_pointer(p_reference);
@@ -176,6 +210,9 @@ class Ref {
 
 	Ref(const Variant &p_variant) {
 		// FIXME
+		// Object::cast_to<T> does not work reliably, see: https://github.com/godotengine/godot-cpp/issues/610
+		// As variant stores our Godot pointer (_owner) we can't reliably cast here until we fix the above mentioned issue
+
 		// Object *object = p_variant.get_validated_object();
 
 		// if (!object) {