Implement Ref copy constructor #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
ref_copy_constructor
branch
from
51dfca2 to
cd08b22
Compare
Collaborator
Author
|
I'll rebase and update this PR once #27 is merged as that fixes the casting logic. |
BastiaanOlij
force-pushed
the
ref_copy_constructor
branch
from
cd08b22 to
9c81caa
Compare
BastiaanOlij
force-pushed
the
ref_copy_constructor
branch
from
9c81caa to
6e6886d
Compare
Faless
reviewed
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @ellenhp suggested solution but with more of the code from Godot in place.
We have a problem with casting as described in godotengine#610, this solution works around that for our reference copy constructor and = operator and I've added remarks on Variant that this is still a problem there.