Skip to content

Conversation

@chlafreniere
Copy link
Collaborator

Bump version to 0.1.1, Update Changelog with quick description of bug fix.

@vors
Copy link
Owner

vors commented Oct 22, 2019

This is a git nit: the commit history should not look like this (it includes old commits)
image

That's not a biggy since you can simply use the "Squash and merge" button to do the right thing, but I suggest to learn how to avoid such things in the future and have a nice intentional commits in PRs.

Copy link
Owner

@vors vors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not merging because you can do it yourself! :)

@chlafreniere
Copy link
Collaborator Author

chlafreniere commented Oct 22, 2019

Thanks, @vors!

Looks like I can't merge myself actually:

image

@vors
Copy link
Owner

vors commented Oct 22, 2019

You need to accept the invitation to be the maintainer

image

Here is a link to accept: https://github.com/vors/jupyter-powershell/invitations

@chlafreniere chlafreniere merged commit b751b0d into vors:master Oct 22, 2019
@chlafreniere chlafreniere deleted the updateto011 branch October 22, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants