chore: remove deprecated vectorizer parameter

Author: bevzzz

src/main/java/io/weaviate/client6/v1/api/collections/vectorizers/Multi2VecClipVectorizer.java

@@ -13,7 +13,6 @@
 import io.weaviate.client6.v1.internal.ObjectBuilder;
 
 public record Multi2VecClipVectorizer(
-    @SerializedName("vectorizeClassName") boolean vectorizeCollectionName,
     @SerializedName("inferenceUrl") String inferenceUrl,
     @SerializedName("imageFields") List<String> imageFields,
     @SerializedName("textFields") List<String> textFields,
@@ -45,7 +44,6 @@ public static Multi2VecClipVectorizer of(Function<Builder, ObjectBuilder<Multi2V
 
   public Multi2VecClipVectorizer(Builder builder) {
     this(
-        builder.vectorizeCollectionName,
         builder.inferenceUrl,
         builder.imageFields.keySet().stream().toList(),
         builder.textFields.keySet().stream().toList(),
@@ -57,7 +55,6 @@ public Multi2VecClipVectorizer(Builder builder) {
 
   public static class Builder implements ObjectBuilder<Multi2VecClipVectorizer> {
     private VectorIndex vectorIndex = VectorIndex.DEFAULT_VECTOR_INDEX;
-    private boolean vectorizeCollectionName = false;
     private String inferenceUrl;
     private Map<String, Float> imageFields = new HashMap<>();
     private Map<String, Float> textFields = new HashMap<>();
@@ -95,11 +92,6 @@ public Builder textField(String field, float weight) {
       return this;
     }
 
-    public Builder vectorizeCollectionName(boolean enable) {
-      this.vectorizeCollectionName = enable;
-      return this;
-    }
-
     public Builder vectorIndex(VectorIndex vectorIndex) {
       this.vectorIndex = vectorIndex;
       return this;

src/main/java/io/weaviate/client6/v1/api/collections/vectorizers/Text2VecContextionaryVectorizer.java

@@ -9,7 +9,15 @@
 import io.weaviate.client6.v1.internal.ObjectBuilder;
 
 public record Text2VecContextionaryVectorizer(
-    @SerializedName("vectorizeClassName") boolean vectorizeCollectionName,
+    /**
+     * Weaviate defaults to {@code true} if the value is not provided.
+     * Because text2vec-contextionary cannot handle understores in collection names,
+     * this quickly becomes inconvenient.
+     *
+     * To avoid that we send "vectorizeClassName": false all the time
+     * and make it impossible to enable this feature, as it is deprecated.
+     */
+    @Deprecated @SerializedName("vectorizeClassName") boolean vectorizeCollectionName,
     VectorIndex vectorIndex) implements Vectorizer {
 
   @Override
@@ -31,18 +39,22 @@ public static Text2VecContextionaryVectorizer of(
     return fn.apply(new Builder()).build();
   }
 
+  /**
+   * Canonical constructor always sets {@link #vectorizeCollectionName} to false.
+   */
+  public Text2VecContextionaryVectorizer(boolean vectorizeCollectionName, VectorIndex vectorIndex) {
+    this.vectorizeCollectionName = false;
+    this.vectorIndex = vectorIndex;
+  }
+
   public Text2VecContextionaryVectorizer(Builder builder) {
     this(builder.vectorizeCollectionName, builder.vectorIndex);
   }
 
   public static class Builder implements ObjectBuilder<Text2VecContextionaryVectorizer> {
-    private VectorIndex vectorIndex = VectorIndex.DEFAULT_VECTOR_INDEX;
-    private boolean vectorizeCollectionName = false;
+    private final boolean vectorizeCollectionName = false;
 
-    public Builder vectorizeCollectionName(boolean enable) {
-      this.vectorizeCollectionName = enable;
-      return this;
-    }
+    private VectorIndex vectorIndex = VectorIndex.DEFAULT_VECTOR_INDEX;
 
     public Builder vectorIndex(VectorIndex vectorIndex) {
       this.vectorIndex = vectorIndex;

src/main/java/io/weaviate/client6/v1/api/collections/vectorizers/Text2VecWeaviateVectorizer.java

@@ -9,7 +9,6 @@
 import io.weaviate.client6.v1.internal.ObjectBuilder;
 
 public record Text2VecWeaviateVectorizer(
-    @SerializedName("vectorizeClassName") boolean vectorizeCollectionName,
     @SerializedName("baseUrl") String inferenceUrl,
     @SerializedName("dimensions") Integer dimensions,
     @SerializedName("model") String model,
@@ -34,7 +33,7 @@ public static Text2VecWeaviateVectorizer of(Function<Builder, ObjectBuilder<Text
   }
 
   public Text2VecWeaviateVectorizer(Builder builder) {
-    this(builder.vectorizeCollectionName,
+    this(
         builder.inferenceUrl,
         builder.dimensions,
         builder.model,
@@ -46,16 +45,10 @@ public Text2VecWeaviateVectorizer(Builder builder) {
 
   public static class Builder implements ObjectBuilder<Text2VecWeaviateVectorizer> {
     private VectorIndex vectorIndex = VectorIndex.DEFAULT_VECTOR_INDEX;
-    private boolean vectorizeCollectionName = false;
     private String inferenceUrl;
     private Integer dimensions;
     private String model;
 
-    public Builder vectorizeCollectionName(boolean enable) {
-      this.vectorizeCollectionName = enable;
-      return this;
-    }
-
     public Builder inferenceUrl(String inferenceUrl) {
       this.inferenceUrl = inferenceUrl;
       return this;

src/test/java/io/weaviate/client6/v1/internal/json/JSONTest.java

@@ -73,16 +73,14 @@ public static Object[][] testCases() {
             Multi2VecClipVectorizer.of(m2v -> m2v
                 .inferenceUrl("http://example.com")
                 .imageField("img", 1f)
-                .textField("txt", 2f)
-                .vectorizeCollectionName(true)),
+                .textField("txt", 2f)),
             """
                 {
                   "vectorIndexType": "hnsw",
                   "vectorIndexConfig": {},
                   "vectorizer": {
                     "multi2vec-clip": {
                       "inferenceUrl": "http://example.com",
-                      "vectorizeClassName": true,
                       "imageFields": ["img"],
                       "textFields": ["txt"],
                       "weights": {
@@ -96,15 +94,14 @@ public static Object[][] testCases() {
         },
         {
             Vectorizer.class,
-            Text2VecContextionaryVectorizer.of(t2v -> t2v
-                .vectorizeCollectionName(true)),
+            Text2VecContextionaryVectorizer.of(),
             """
                 {
                   "vectorIndexType": "hnsw",
                   "vectorIndexConfig": {},
                   "vectorizer": {
                     "text2vec-contextionary": {
-                      "vectorizeClassName": true
+                      "vectorizeClassName": false
                     }
                   }
                 }
@@ -115,16 +112,14 @@ public static Object[][] testCases() {
             Text2VecWeaviateVectorizer.of(t2v -> t2v
                 .inferenceUrl("http://example.com")
                 .dimensions(4)
-                .model("very-good-model")
-                .vectorizeCollectionName(true)),
+                .model("very-good-model")),
             """
                 {
                   "vectorIndexType": "hnsw",
                   "vectorIndexConfig": {},
                   "vectorizer": {
                     "text2vec-weaviate": {
                       "baseUrl": "http://example.com",
-                      "vectorizeClassName": true,
                       "dimensions": 4,
                       "model": "very-good-model"
                     }