ci: add Node.js 24 (#1136)

Author: alexander-akait

.github/workflows/nodejs.yml

@@ -67,7 +67,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
+        node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x]
         webpack-version: [latest]
 
     runs-on: ${{ matrix.os }}
@@ -127,7 +127,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
+        node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x]
 
     runs-on: ${{ matrix.os }}
 

test/TestCases.test.js

@@ -23,15 +23,19 @@ function clearDirectory(dirPath) {
     for (let i = 0; i < files.length; i++) {
       const filePath = `${dirPath}/${files[i]}`;
 
-      if (fs.statSync(filePath).isFile()) {
+      if (fs.existsSync(filePath) && fs.statSync(filePath).isFile()) {
         fs.unlinkSync(filePath);
       } else {
         clearDirectory(filePath);
       }
     }
   }
 
-  fs.rmdirSync(dirPath);
+  try {
+    fs.rmdirSync(dirPath);
+  } catch (_err) {
+    // Nothing
+  }
 }
 
 function compareDirectory(actual, expected) {

test/emit-option.test.js

@@ -315,42 +315,38 @@ describe("emit option", () => {
 
     await del([outputPath]);
 
-    const compiler1 = webpack(webpackConfig);
+    const compiler = webpack(webpackConfig);
 
     await new Promise((resolve, reject) => {
-      compiler1.run((error, stats) => {
+      compiler.run((error, stats) => {
         if (error) {
           reject(error);
 
           return;
         }
 
-        compiler1.close(() => {
-          expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
-            `assets`
-          );
-          expect(
-            Array.from(stats.compilation.emittedAssets).sort()
-          ).toMatchSnapshot(`emittedAssets`);
-          expect(getWarnings(stats)).toMatchSnapshot("warnings");
-          expect(getErrors(stats)).toMatchSnapshot("errors");
+        expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
+          `assets`
+        );
+        expect(
+          Array.from(stats.compilation.emittedAssets).sort()
+        ).toMatchSnapshot(`emittedAssets`);
+        expect(getWarnings(stats)).toMatchSnapshot("warnings");
+        expect(getErrors(stats)).toMatchSnapshot("errors");
 
-          resolve();
-        });
+        resolve();
       });
     });
 
-    const compiler2 = webpack(webpackConfig);
-
     await new Promise((resolve, reject) => {
-      compiler2.run((error, stats) => {
+      compiler.run((error, stats) => {
         if (error) {
           reject(error);
 
           return;
         }
 
-        compiler2.close(() => {
+        compiler.close(() => {
           expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
             `assets`
           );