fix: ignore modules without identifier (#627)

Author: evilebottnawi

package-lock.json

@@ -49,24 +49,24 @@
     "webpack-sources": "^1.1.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.11.6",
-    "@babel/core": "^7.11.6",
-    "@babel/preset-env": "^7.11.5",
+    "@babel/cli": "^7.12.1",
+    "@babel/core": "^7.12.3",
+    "@babel/preset-env": "^7.12.1",
     "@commitlint/cli": "^11.0.0",
     "@commitlint/config-conventional": "^11.0.0",
     "@webpack-contrib/defaults": "^6.3.0",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
-    "babel-eslint": "^10.0.2",
+    "babel-eslint": "^10.1.0",
     "babel-jest": "^26.5.2",
     "cross-env": "^7.0.2",
-    "css-loader": "^4.3.0",
+    "css-loader": "^5.0.0",
     "del": "^6.0.0",
     "del-cli": "^3.0.1",
     "es-check": "^5.1.1",
-    "eslint": "^7.10.0",
-    "eslint-config-prettier": "^6.12.0",
+    "eslint": "^7.11.0",
+    "eslint-config-prettier": "^6.13.0",
     "eslint-plugin-import": "^2.22.1",
-    "file-loader": "^6.1.0",
+    "file-loader": "^6.1.1",
     "husky": "^4.3.0",
     "jest": "^26.5.2",
     "jsdom": "^16.4.0",
@@ -76,7 +76,7 @@
     "prettier": "^2.1.2",
     "standard-version": "^9.0.0",
     "webpack": "^5.1.0",
-    "webpack-cli": "^3.3.6",
+    "webpack-cli": "^4.1.0",
     "webpack-dev-server": "^3.7.2"
   },
   "keywords": [

package.json

@@ -150,6 +150,11 @@ export function pitch(request) {
       const identifierCountMap = new Map();
 
       for (const dependency of dependencies) {
+        if (!dependency.identifier) {
+          // eslint-disable-next-line no-continue
+          continue;
+        }
+
         const count = identifierCountMap.get(dependency.identifier) || 0;
 
         this._module.addDependency(
@@ -197,7 +202,10 @@ export function pitch(request) {
       if (namedExport) {
         Object.keys(originalExports).forEach((key) => {
           if (key !== 'default') {
-            if (!locals) locals = {};
+            if (!locals) {
+              locals = {};
+            }
+
             locals[key] = originalExports[key];
           }
         });

src/loader.js

@@ -192,7 +192,7 @@ describe('TestCases', () => {
               outputDirectoryForCase,
               expectedDirectoryByVersion
             );
-          } else {
+          } else if (fs.existsSync(expectedDirectory)) {
             compareDirectory(outputDirectoryForCase, expectedDirectory);
           }
 

test/TestCases.test.js

@@ -0,0 +1 @@
+import './style.css';

test/cases/no-identifier/index.js

@@ -0,0 +1,11 @@
+.a {
+  background: red;
+}
+
+:local(.b) {
+  color: green;
+}
+
+:global(.c) {
+  color: blue;
+}

test/cases/no-identifier/style.css

@@ -0,0 +1,30 @@
+import Self from '../../../src';
+
+module.exports = {
+  entry: './index.js',
+  module: {
+    rules: [
+      {
+        test: /\.css$/,
+        use: [
+          Self.loader,
+          {
+            loader: 'css-loader',
+            options: {
+              modules: {
+                mode: 'local',
+                localIdentName: 'foo__[name]__[local]',
+                exportOnlyLocals: true,
+              },
+            },
+          },
+        ],
+      },
+    ],
+  },
+  plugins: [
+    new Self({
+      filename: '[name].css',
+    }),
+  ],
+};