feat: support configuration via title

Author: alexander-akait

src/ValidationError.js

@@ -408,10 +408,30 @@ class ValidationError extends Error {
     this.errors = errors;
     /** @type {Schema} */
     this.schema = schema;
+
+    let headerNameFromSchema;
+    let baseDataPathFromSchema;
+
+    if (schema.title && (!configuration.name || !configuration.baseDataPath)) {
+      const splittedTitleFromSchema = schema.title.match(/^(.+) (.+)$/);
+
+      if (splittedTitleFromSchema) {
+        if (!configuration.name) {
+          [, headerNameFromSchema] = splittedTitleFromSchema;
+        }
+
+        if (!configuration.name) {
+          [, , baseDataPathFromSchema] = splittedTitleFromSchema;
+        }
+      }
+    }
+
     /** @type {string} */
-    this.headerName = configuration.name || 'Object';
+    this.headerName = configuration.name || headerNameFromSchema || 'Object';
     /** @type {string} */
-    this.baseDataPath = configuration.baseDataPath || 'configuration';
+    this.baseDataPath =
+      configuration.baseDataPath || baseDataPathFromSchema || 'configuration';
+
     /** @type {PostFormatter | null} */
     this.postFormatter = configuration.postFormatter || null;
 

test/__snapshots__/api.test.js.snap

@@ -0,0 +1,31 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`api should get configuration from schema 1`] = `
+"Invalid options object. CSS Loader has been initialised using an options object that does not match the API schema.
+ - options has an unknown property 'foo'. These properties are valid:
+   object { name? }"
+`;
+
+exports[`api should prefer configuration over "title" #1 1`] = `
+"Invalid configuration object. NAME has been initialised using a configuration object that does not match the API schema.
+ - configuration has an unknown property 'foo'. These properties are valid:
+   object { name? }"
+`;
+
+exports[`api should prefer configuration over "title" #2 1`] = `
+"Invalid BaseDataPath object. CSS Loader has been initialised using a BaseDataPath object that does not match the API schema.
+ - BaseDataPath has an unknown property 'foo'. These properties are valid:
+   object { name? }"
+`;
+
+exports[`api should prefer configuration over "title" 1`] = `
+"Invalid BaseDataPath object. NAME has been initialised using a BaseDataPath object that does not match the API schema.
+ - BaseDataPath has an unknown property 'foo'. These properties are valid:
+   object { name? }"
+`;
+
+exports[`api should use default values when "title" is broken 1`] = `
+"Invalid configuration object. Object has been initialised using a configuration object that does not match the API schema.
+ - configuration has an unknown property 'foo'. These properties are valid:
+   object { name? }"
+`;

test/api.test.js

@@ -1,6 +1,8 @@
 import schemaUtils from '../src/index';
 
 import schema from './fixtures/schema.json';
+import schemaTitle from './fixtures/schema-title.json';
+import schemaTitleBrone from './fixtures/schema-title-broken.json';
 
 describe('api', () => {
   it('should export validate and ValidateError', () => {
@@ -32,4 +34,72 @@ describe('api', () => {
 
     schemaUtils(schema, options);
   });
+
+  it('should get configuration from schema', () => {
+    try {
+      schemaUtils(schemaTitle, { foo: 'bar' });
+    } catch (error) {
+      if (error.name !== 'ValidationError') {
+        throw error;
+      }
+
+      expect(error.message).toMatchSnapshot();
+    }
+  });
+
+  it('should prefer configuration over "title"', () => {
+    try {
+      schemaUtils(
+        schemaTitle,
+        { foo: 'bar' },
+        { name: 'NAME', baseDataPath: 'BaseDataPath' }
+      );
+    } catch (error) {
+      if (error.name !== 'ValidationError') {
+        throw error;
+      }
+
+      expect(error.message).toMatchSnapshot();
+    }
+  });
+
+  it('should prefer configuration over "title" #1', () => {
+    try {
+      schemaUtils(schemaTitle, { foo: 'bar' }, { name: 'NAME' });
+    } catch (error) {
+      if (error.name !== 'ValidationError') {
+        throw error;
+      }
+
+      expect(error.message).toMatchSnapshot();
+    }
+  });
+
+  it('should prefer configuration over "title" #2', () => {
+    try {
+      schemaUtils(
+        schemaTitle,
+        { foo: 'bar' },
+        { baseDataPath: 'BaseDataPath' }
+      );
+    } catch (error) {
+      if (error.name !== 'ValidationError') {
+        throw error;
+      }
+
+      expect(error.message).toMatchSnapshot();
+    }
+  });
+
+  it('should use default values when "title" is broken', () => {
+    try {
+      schemaUtils(schemaTitleBrone, { foo: 'bar' });
+    } catch (error) {
+      if (error.name !== 'ValidationError') {
+        throw error;
+      }
+
+      expect(error.message).toMatchSnapshot();
+    }
+  });
 });

test/fixtures/schema-title-broken.json

@@ -0,0 +1,10 @@
+{
+  "title": "CSSLoaderoptions",
+  "additionalProperties": false,
+  "properties": {
+    "name": {
+      "type": "boolean"
+    }
+  },
+  "type": "object"
+}

test/fixtures/schema-title.json

@@ -0,0 +1,10 @@
+{
+  "title": "CSS Loader options",
+  "additionalProperties": false,
+  "properties": {
+    "name": {
+      "type": "boolean"
+    }
+  },
+  "type": "object"
+}