fix(addStyles): correctly check singleton behavior when {Boolean} (options.singleton)
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joshwiens
approved these changes
Dec 14, 2017
michael-ciniawsky
approved these changes
Dec 14, 2017
michael-ciniawsky
changed the title
singleton option behavior when booleansingleton behavior when {Boolean} (options.singleton)
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
pr_action: Review
severity: 5 (confusing)
labels
This was referenced Oct 4, 2019
This was referenced Nov 7, 2019
This was referenced Feb 23, 2020
This was referenced Apr 1, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the README?
yes, we don't have
singletonoption in table options, i don't know how it is happensSummary
When
singleton: true- i want to use onestyletag.When
singleton: false- i want to use multiplestyletags.When
singletonnot specify (i.e.undefined) - i want the loader himself decide to use single or multiplestyletags.Issue: #283
Does this PR introduce a breaking change?
No
Other information