Don't add deny rule if no CIDR list is passed (apache#62)

Pearl1594 · web-flow · commit 9ed5bb1428dd · 2025-03-17T11:24:32.000-03:00
diff --git a/plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java b/plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java
@@ -726,7 +726,7 @@ public boolean createOrUpdateLbRule(CreateOrUpdateNetrisLoadBalancerRuleCommand
             if (ObjectUtils.allNull(editResponse, createResponse) || Boolean.FALSE.equals(success)) {
                 throw new CloudRuntimeException(String.format("Failed to %s Netris LB rule", updateRule ? "update" : "create"));
             }
-            if (Objects.nonNull(cmd.getCidrList())) {
+            if (Objects.nonNull(cmd.getCidrList()) && !cmd.getCidrList().isEmpty()) {
                 applyAclRulesForLb(cmd, lbName);
             }
         } catch (ApiException e) {

Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,7 @@ public boolean createOrUpdateLbRule(CreateOrUpdateNetrisLoadBalancerRuleCommand`
`726`	`726`	`if (ObjectUtils.allNull(editResponse, createResponse) \|\| Boolean.FALSE.equals(success)) {`
`727`	`727`	`throw new CloudRuntimeException(String.format("Failed to %s Netris LB rule", updateRule ? "update" : "create"));`
`728`	`728`	`}`
`729`		`- if (Objects.nonNull(cmd.getCidrList())) {`
	`729`	`+ if (Objects.nonNull(cmd.getCidrList()) && !cmd.getCidrList().isEmpty()) {`
`730`	`730`	`applyAclRulesForLb(cmd, lbName);`
`731`	`731`	`}`
`732`	`732`	`} catch (ApiException e) {`