Skip to content

Commit 1b5743f

Browse files
yannickcryannickcr
committed
Update tests to pass parserOptions globally
1 parent 0a2c510 commit 1b5743f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+1240
-2310
lines changed

‎tests/lib/rules/display-name.js‎

Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ var RuleTester = require('eslint').RuleTester;
1414
require('babel-eslint');
1515

1616
var parserOptions = {
17-
ecmaVersion: 6,
17+
ecmaVersion: 8,
18+
sourceType: 'module',
1819
ecmaFeatures: {
1920
experimentalObjectRestSpread: true,
2021
jsx: true
@@ -25,7 +26,7 @@ var parserOptions = {
2526
// Tests
2627
// ------------------------------------------------------------------------------
2728

28-
var ruleTester = new RuleTester();
29+
var ruleTester = new RuleTester({parserOptions});
2930
ruleTester.run('display-name', rule, {
3031

3132
valid: [{
@@ -39,8 +40,7 @@ ruleTester.run('display-name', rule, {
3940
].join('\n'),
4041
options: [{
4142
ignoreTranspilerName: true
42-
}],
43-
parserOptions: parserOptions
43+
}]
4444
}, {
4545
code: [
4646
'var Hello = React.createClass({',
@@ -57,8 +57,7 @@ ruleTester.run('display-name', rule, {
5757
react: {
5858
createClass: 'createClass'
5959
}
60-
},
61-
parserOptions: parserOptions
60+
}
6261
}, {
6362
code: [
6463
'class Hello extends React.Component {',
@@ -70,17 +69,15 @@ ruleTester.run('display-name', rule, {
7069
].join('\n'),
7170
options: [{
7271
ignoreTranspilerName: true
73-
}],
74-
parserOptions: parserOptions
72+
}]
7573
}, {
7674
code: [
7775
'class Hello {',
7876
' render() {',
7977
' return \'Hello World\';',
8078
' }',
8179
'}'
82-
].join('\n'),
83-
parserOptions: parserOptions
80+
].join('\n')
8481
}, {
8582
code: [
8683
'class Hello extends Greetings {',
@@ -97,8 +94,7 @@ ruleTester.run('display-name', rule, {
9794
' method;',
9895
'}'
9996
].join('\n'),
100-
parser: 'babel-eslint',
101-
parserOptions: parserOptions
97+
parser: 'babel-eslint'
10298
}, {
10399
code: [
104100
'class Hello extends React.Component {',
@@ -112,8 +108,7 @@ ruleTester.run('display-name', rule, {
112108
].join('\n'),
113109
options: [{
114110
ignoreTranspilerName: true
115-
}],
116-
parserOptions: parserOptions
111+
}]
117112
}, {
118113
code: [
119114
'class Hello extends React.Component {',
@@ -126,17 +121,15 @@ ruleTester.run('display-name', rule, {
126121
options: [{
127122
ignoreTranspilerName: true
128123
}],
129-
parser: 'babel-eslint',
130-
parserOptions: parserOptions
124+
parser: 'babel-eslint'
131125
}, {
132126
code: [
133127
'var Hello = createReactClass({',
134128
' render: function() {',
135129
' return <div>Hello {this.props.name}</div>;',
136130
' }',
137131
'});'
138-
].join('\n'),
139-
parserOptions: parserOptions
132+
].join('\n')
140133
}, {
141134
code: [
142135
'class Hello extends React.Component {',
@@ -163,8 +156,7 @@ ruleTester.run('display-name', rule, {
163156
' return <div>Hello {this.props.name}</div>;',
164157
' }',
165158
'});'
166-
].join('\n'),
167-
parserOptions: parserOptions
159+
].join('\n')
168160
}, {
169161
code: [
170162
'module.exports = createReactClass({',
@@ -173,8 +165,7 @@ ruleTester.run('display-name', rule, {
173165
' return <div>Hello {this.props.name}</div>;',
174166
' }',
175167
'});'
176-
].join('\n'),
177-
parserOptions: parserOptions
168+
].join('\n')
178169
}, {
179170
code: [
180171
'var Hello = createReactClass({',
@@ -188,8 +179,7 @@ ruleTester.run('display-name', rule, {
188179
].join('\n'),
189180
options: [{
190181
ignoreTranspilerName: true
191-
}],
192-
parserOptions: parserOptions
182+
}]
193183
}, {
194184
code: [
195185
'export default class {',
@@ -421,7 +411,6 @@ ruleTester.run('display-name', rule, {
421411
options: [{
422412
ignoreTranspilerName: true
423413
}],
424-
parserOptions: parserOptions,
425414
errors: [{
426415
message: 'Component definition is missing display name'
427416
}]
@@ -441,7 +430,6 @@ ruleTester.run('display-name', rule, {
441430
createClass: 'createClass'
442431
}
443432
},
444-
parserOptions: parserOptions,
445433
errors: [{
446434
message: 'Component definition is missing display name'
447435
}]
@@ -456,7 +444,6 @@ ruleTester.run('display-name', rule, {
456444
options: [{
457445
ignoreTranspilerName: true
458446
}],
459-
parserOptions: parserOptions,
460447
errors: [{
461448
message: 'Component definition is missing display name'
462449
}]
@@ -471,7 +458,6 @@ ruleTester.run('display-name', rule, {
471458
options: [{
472459
ignoreTranspilerName: true
473460
}],
474-
parserOptions: parserOptions,
475461
errors: [{
476462
message: 'Component definition is missing display name'
477463
}]
@@ -489,7 +475,6 @@ ruleTester.run('display-name', rule, {
489475
options: [{
490476
ignoreTranspilerName: true
491477
}],
492-
parserOptions: parserOptions,
493478
errors: [{
494479
message: 'Component definition is missing display name'
495480
}]

‎tests/lib/rules/forbid-component-props.js‎

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ var rule = require('../../../lib/rules/forbid-component-props');
1111
var RuleTester = require('eslint').RuleTester;
1212

1313
var parserOptions = {
14-
ecmaVersion: 6,
14+
ecmaVersion: 8,
15+
sourceType: 'module',
1516
ecmaFeatures: {
1617
experimentalObjectRestSpread: true,
1718
jsx: true
@@ -27,7 +28,7 @@ require('babel-eslint');
2728
var CLASSNAME_ERROR_MESSAGE = 'Prop `className` is forbidden on Components';
2829
var STYLE_ERROR_MESSAGE = 'Prop `style` is forbidden on Components';
2930

30-
var ruleTester = new RuleTester();
31+
var ruleTester = new RuleTester({parserOptions});
3132
ruleTester.run('forbid-component-props', rule, {
3233

3334
valid: [{
@@ -37,8 +38,7 @@ ruleTester.run('forbid-component-props', rule, {
3738
' return <div className="foo" />;',
3839
' }',
3940
'});'
40-
].join('\n'),
41-
parserOptions: parserOptions
41+
].join('\n')
4242
}, {
4343
code: [
4444
'var First = createReactClass({',
@@ -47,8 +47,7 @@ ruleTester.run('forbid-component-props', rule, {
4747
' }',
4848
'});'
4949
].join('\n'),
50-
options: [{forbid: ['style']}],
51-
parserOptions: parserOptions
50+
options: [{forbid: ['style']}]
5251
}, {
5352
code: [
5453
'var First = createReactClass({',
@@ -57,8 +56,7 @@ ruleTester.run('forbid-component-props', rule, {
5756
' return <Foo bar="baz" />;',
5857
' }',
5958
'});'
60-
].join('\n'),
61-
parserOptions: parserOptions
59+
].join('\n')
6260
}, {
6361
code: [
6462
'var First = createReactClass({',
@@ -68,8 +66,7 @@ ruleTester.run('forbid-component-props', rule, {
6866
' }',
6967
'});'
7068
].join('\n'),
71-
options: [{forbid: ['style']}],
72-
parserOptions: parserOptions
69+
options: [{forbid: ['style']}]
7370
}, {
7471
code: [
7572
'var First = createReactClass({',
@@ -79,8 +76,7 @@ ruleTester.run('forbid-component-props', rule, {
7976
' }',
8077
'});'
8178
].join('\n'),
82-
options: [{forbid: ['style', 'foo']}],
83-
parserOptions: parserOptions
79+
options: [{forbid: ['style', 'foo']}]
8480
}, {
8581
code: [
8682
'var First = createReactClass({',
@@ -89,8 +85,7 @@ ruleTester.run('forbid-component-props', rule, {
8985
' return <this.Foo bar="baz" />;',
9086
' }',
9187
'});'
92-
].join('\n'),
93-
parserOptions: parserOptions
88+
].join('\n')
9489
}, {
9590
code: [
9691
'class First extends createReactClass {',
@@ -99,15 +94,13 @@ ruleTester.run('forbid-component-props', rule, {
9994
' }',
10095
'}'
10196
].join('\n'),
102-
options: [{forbid: ['style']}],
103-
parserOptions: parserOptions
97+
options: [{forbid: ['style']}]
10498
}, {
10599
code: [
106100
'const First = (props) => (',
107101
' <this.Foo {...props} />',
108102
');'
109-
].join('\n'),
110-
parserOptions: parserOptions
103+
].join('\n')
111104
}],
112105

113106
invalid: [{
@@ -119,7 +112,6 @@ ruleTester.run('forbid-component-props', rule, {
119112
' }',
120113
'});'
121114
].join('\n'),
122-
parserOptions: parserOptions,
123115
errors: [{
124116
message: CLASSNAME_ERROR_MESSAGE,
125117
line: 4,
@@ -135,7 +127,6 @@ ruleTester.run('forbid-component-props', rule, {
135127
' }',
136128
'});'
137129
].join('\n'),
138-
parserOptions: parserOptions,
139130
errors: [{
140131
message: STYLE_ERROR_MESSAGE,
141132
line: 4,
@@ -151,7 +142,6 @@ ruleTester.run('forbid-component-props', rule, {
151142
' }',
152143
'});'
153144
].join('\n'),
154-
parserOptions: parserOptions,
155145
options: [{forbid: ['className', 'style']}],
156146
errors: [{
157147
message: CLASSNAME_ERROR_MESSAGE,
@@ -168,7 +158,6 @@ ruleTester.run('forbid-component-props', rule, {
168158
' }',
169159
'});'
170160
].join('\n'),
171-
parserOptions: parserOptions,
172161
options: [{forbid: ['className', 'style']}],
173162
errors: [{
174163
message: STYLE_ERROR_MESSAGE,

0 commit comments

Comments
 (0)