feat(request-manager): fail on status_code >= 400

Author: lechinoix

__tests__/util/request-manager.js

@@ -225,3 +225,27 @@ test('RequestManager.saveHar no captureHar error message', async () => {
     expect(err.message).toBe('RequestManager was not setup to capture HAR files');
   }
 });
+
+test('RequestManager.execute Request 4xx or 5xx error', async () => {
+  jest.resetModules();
+  const config = await Config.create({}, new Reporter());
+  jest.mock('request', factory => options => {
+    const errorStatusCode = Math.floor(Math.random() * (600 - 400) + 400); // random error code between 400 and 599
+    options.callback('', {statusCode: errorStatusCode}, '');
+    return {
+      on: () => {},
+    };
+  });
+  await config.requestManager.execute({
+    params: {
+      url: `https://localhost:port/?nocache`,
+      headers: {Connection: 'close'},
+    },
+    resolve: body => {},
+    reject: err => {
+      expect(
+        err.message.startsWith('https://localhost:port/?nocache: Request "https://localhost:port/?nocache" returned a'),
+      ).toBe(true);
+    },
+  });
+});

src/util/request-manager.js

@@ -388,21 +388,20 @@ export default class RequestManager {
         successHosts[parts.hostname] = true;
 
         this.reporter.verbose(this.reporter.lang('verboseRequestFinish', params.url, res.statusCode));
-
         if (body && typeof body.error === 'string') {
           reject(new Error(body.error));
           return;
         }
 
-        if (res.statusCode === 403) {
-          const errMsg = (body && body.message) || reporter.lang('requestError', params.url, res.statusCode);
-          reject(new Error(errMsg));
+        if ([400, 401, 404].concat(params.rejectStatusCode || []).indexOf(res.statusCode) !== -1) {
+          body = false;
         } else {
-          if ([400, 401, 404].concat(params.rejectStatusCode || []).indexOf(res.statusCode) !== -1) {
-            body = false;
+          if (res.statusCode >= 400) {
+            const errMsg = (body && body.message) || reporter.lang('requestError', params.url, res.statusCode);
+            reject(new Error(errMsg));
           }
-          resolve(body);
         }
+        resolve(body);
       };
     }