fix(coverpage): resolve bugs with non-default coverpage #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.typ
Outdated
| } | ||
| } | ||
|
|
||
| states.print-answers.update(it => print-answers) |
There was a problem hiding this comment.
Does this line need to remain? I feel like it would make more sense to remove it and mandate that coverpages that rely on print-answers must set it themselves?
There was a problem hiding this comment.
I think this makes sense, but only if we also do this on the default coverpage (IE: state management doesn't happen at all around coverpage, and the built-in coverpage.typ sets this itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current coverpage implementation compares with
stringinstead ofstr, so linking to another document does not work correctly.It also sets
coverpage = function()when a function is passed in, so the result of the function is never rendered to the document.Finally, it only updates solution visibility in the main path, so using a custom coverpage breaks showing or hiding solutions.
This PR resolves these three things.