Skip to content

Conversation

@Ocean-OS
Copy link

Changes

I have added a few things:

  • Added an event listener that detects any keypresses on the page, not necessarily on the input, and if the key is a text character, it adds it to the input value. It also detects if the Enter key was pressed on the page, so the input does not need to be selected at all for the scanner to work.
  • Created a slightly more secure encoding system for the PIN, so someone can't just Ctrl+Shift+I to easily find it
  • In case my keypress system does not work as expected, I made it so that checkInSillyGuy does not cause any problems (e.g. sending the Enter keypress signal twice) by adding a date checking feature in the search function, so that if the search function is called twice in half a second, it will not do the search function twice.

Testing

I have not tested the full Svelte app, but I have tested the individual parts of the code I added. The code should probably be tweaked to either remove or merge checkInSillyGuy with my listener function, once the code is fully tested.

@netlify
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for 6305roster ready!

Name Link
🔨 Latest commit 9502521
🔍 Latest deploy log https://app.netlify.com/sites/6305roster/deploys/65b0a47641e99c0008fcb80b
😎 Deploy Preview https://deploy-preview-1--6305roster.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89
Accessibility: 96
Best Practices: 92
SEO: 82
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant