Simplify OSL shader generator for surfaceshader
output
#2509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the OSL shader generator is passed an element that outputs a single
surfaceshader
type, then it injects the shader code from the OSL implementation ofsurfacematerial
node. Because thesurfaceshader
type is a struct and it needs to be resolved down to aclosure color
for output.This PR modifies the shader generator to insert an instance of the
surfacematerial
node, instead of hardcoding the shader source in the shader generator. This decouples the library, and means we just have a single source of truth for the shader code in thesurfacematerial
node for OSL.Adds a new API call on the
ShaderGraph
node to insert a node upstream of an output of the graph.