Fix Python Interfaces For Image Loaders #2541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sample OIIO Loader test added.
kwokcb
commented
Sep 3, 2025
| @@ -10,11 +10,18 @@ | |||
| namespace py = pybind11; | |||
| namespace mx = MaterialX; | |||
|
|
|||
| uintptr_t getResourceBuffer(const mx::Image& image) | |||
There was a problem hiding this comment.
Cannot pass back and forth void pointers for buffer data.
Add a concrete type to wrap.
| @@ -18,7 +18,39 @@ void bindPyImageHandler(py::module& mod) | |||
| .def_readwrite("filterType", &mx::ImageSamplingProperties::filterType) | |||
| .def_readwrite("defaultColor", &mx::ImageSamplingProperties::defaultColor); | |||
|
|
|||
| py::class_<mx::ImageLoader, mx::ImageLoaderPtr>(mod, "ImageLoader") | |||
| // Trampoline class for Python overrides | |||
There was a problem hiding this comment.
Since this glue code was not added, Python loader code would never be called.
| void bindPyImage(py::module& mod) | ||
| { | ||
| py::enum_<mx::Image::BaseType>(mod, "BaseType") | ||
| .value("UINT8", mx::Image::BaseType::UINT8) | ||
| .value("INT8", mx::Image::BaseType::INT8) |
| @@ -0,0 +1,429 @@ | |||
| """ | |||
There was a problem hiding this comment.
Sample code which works for EXR and other image types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Tests
ImageHanderinterfaceaquireImagewhich will check extensions EXR is not by default supported so will find the sample OIIO loaderloadImageoverride. Also displays the image usingmatplotlibif availableImageis cached in memory after load.saveImageon theImageHandlerpassing the MaterialXImagewhich will again check extensions and call back to the OIIO loader.saveImageoverride. Also displays the imsage usingmatplotlibif available.Results:
Possible Integration
This is a possible integration where the loader is used inside of the Graph Editor. Two format not supported by default but available via OIIO shown: EXR and WEBP