Skip to content

Conversation

ld-kerley
Copy link
Contributor

Create separate header for the shader generation exception. This reduces the dependency on the shader generator header.

Note - the exception header is still included in the main shader generation header for backwards compatibility

@ld-kerley ld-kerley force-pushed the shadergen/separate-exception-header branch from 287da78 to 066bc88 Compare September 17, 2025 00:48
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good proposal to me, thanks @ld-kerley, and I had just minor notes about maintaining existing conventions for include order.

@ld-kerley ld-kerley force-pushed the shadergen/separate-exception-header branch from c46de36 to 3b1e55e Compare September 18, 2025 15:39
@ld-kerley
Copy link
Contributor Author

I think changing .clang-format from

SortIncludes: false

to

SortIncludes: CaseSensitive
IncludeBlocks: Preserve

would perform the sorting that I think you're outlining.

I also think it would be really helpful if these coding conventions were either enforced rigorously by clang-format or that they were documented somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants