Test to see what broke nightly integration tests

.github/workflows/build.yml

@@ -171,10 +171,6 @@ jobs:
             {
                 "ID": "Build-Executor",
                 "Args": ["state", "run", "build-exec"]
-            },
-            {
-                "ID": "Build-MCP",
-                "Args": ["state", "run", "build-mcp"]
             }
           ]
           EOF
@@ -230,11 +226,6 @@ jobs:
         shell: bash
         run: parallelize results Build-Executor
 
-      - # === "Build: MCP" ===
-        name: "Build: MCP"
-        shell: bash
-        run: parallelize results Build-MCP
-
       - # === Prepare Windows Cert ===
         name: Prepare Windows Cert
         shell: bash
@@ -255,7 +246,6 @@ jobs:
           signtool.exe sign -d "ActiveState State Service" -f "Cert.p12" -p ${CODE_SIGNING_PASSWD} ./build/state-svc.exe
           signtool.exe sign -d "ActiveState State Installer" -f "Cert.p12" -p ${CODE_SIGNING_PASSWD} ./build/state-installer.exe
           signtool.exe sign -d "ActiveState State Tool Remote Installer" -f "Cert.p12" -p ${CODE_SIGNING_PASSWD} ./build/state-remote-installer.exe
-          signtool.exe sign -d "ActiveState State MCP" -f "Cert.p12" -p ${CODE_SIGNING_PASSWD} ./build/state-mcp.exe
         env:
           CODE_SIGNING_PASSWD: ${{ secrets.CODE_SIGNING_PASSWD }}
 

activestate.windows.yaml

@@ -7,8 +7,6 @@ constants:
     value: state-exec.exe
   - name: BUILD_INSTALLER_TARGET
     value: state-installer.exe
-  - name: BUILD_MCP_TARGET
-    value: state-mcp.exe
   - name: SVC_BUILDFLAGS
     value: -ldflags="-s -w -H=windowsgui"
   - name: SCRIPT_EXT

activestate.yaml

@@ -10,8 +10,6 @@ constants:
     value: ./cmd/state-installer
   - name: EXECUTOR_PKGS
     value: ./cmd/state-exec
-  - name: MCP_PKGS
-    value: ./cmd/state-mcp
   - name: BUILD_TARGET_PREFIX_DIR
     value: ./build
   - name: BUILD_TARGET
@@ -31,9 +29,6 @@ constants:
     value: state-installer
   - name: BUILD_REMOTE_INSTALLER_TARGET
     value: state-remote-installer
-  - name: BUILD_MCP_TARGET
-    if: ne .OS.Name "Windows"
-    value: state-mcp
   - name: INTEGRATION_TEST_REGEX
     value: 'integration\|automation'
   - name: SET_ENV
@@ -109,9 +104,7 @@ scripts:
         go generate
         popd > /dev/null
       fi
-      TARGET=$BUILD_TARGET_DIR/$constants.BUILD_TARGET
-      echo "Building $TARGET"
-      go build -tags "$GO_BUILD_TAGS" -o $TARGET $constants.CLI_BUILDFLAGS $constants.CLI_PKGS
+      go build -tags "$GO_BUILD_TAGS" -o $BUILD_TARGET_DIR/$constants.BUILD_TARGET $constants.CLI_BUILDFLAGS $constants.CLI_PKGS
   - name: build-svc
     language: bash
     standalone: true
@@ -126,29 +119,16 @@ scripts:
         go generate
         popd > /dev/null
       fi
-      TARGET=$BUILD_TARGET_DIR/$constants.BUILD_DAEMON_TARGET
-      echo "Building $TARGET"
-      go build -tags "$GO_BUILD_TAGS" -o $TARGET $constants.SVC_BUILDFLAGS $constants.DAEMON_PKGS
+      go build -tags "$GO_BUILD_TAGS" -o $BUILD_TARGET_DIR/$constants.BUILD_DAEMON_TARGET $constants.SVC_BUILDFLAGS $constants.DAEMON_PKGS
   - name: build-exec
     description: Builds the State Executor application
     language: bash
     standalone: true
     value: |
       set -e
       $constants.SET_ENV
-      TARGET=$BUILD_TARGET_DIR/$constants.BUILD_EXEC_TARGET
-      echo "Building $TARGET"
-      go build -tags "$GO_BUILD_TAGS" -o $TARGET $constants.CLI_BUILDFLAGS $constants.EXECUTOR_PKGS
-  - name: build-mcp
-    description: Builds the State MCP application
-    language: bash
-    standalone: true
-    value: |
-      set -e
-      $constants.SET_ENV
-      TARGET=$BUILD_TARGET_DIR/$constants.BUILD_MCP_TARGET
-      echo "Building $TARGET"
-      go build -tags "$GO_BUILD_TAGS" -o $TARGET $constants.CLI_BUILDFLAGS $constants.MCP_PKGS
+
+      go build -tags "$GO_BUILD_TAGS" -o $BUILD_TARGET_DIR/$constants.BUILD_EXEC_TARGET $constants.CLI_BUILDFLAGS $constants.EXECUTOR_PKGS
   - name: build-all
     description: Builds all our tools
     language: bash
@@ -165,8 +145,6 @@ scripts:
       $scripts.build-svc.path()
       echo "Building State Executor"
       $scripts.build-exec.path()
-      echo "Building State MCP"
-      $scripts.build-mcp.path()
   - name: build-installer
     language: bash
     standalone: true

cmd/state-installer/cmd.go

@@ -475,7 +475,11 @@ func storeInstallSource(installSource string) {
 		installSource = "state-installer"
 	}
 
-	appData := storage.AppDataPath()
+	appData, err := storage.AppDataPath()
+	if err != nil {
+		multilog.Error("Could not store install source due to AppDataPath error: %s", errs.JoinMessage(err))
+		return
+	}
 	if err := fileutils.WriteFile(filepath.Join(appData, constants.InstallSourceFile), []byte(installSource)); err != nil {
 		multilog.Error("Could not store install source due to WriteFile error: %s", errs.JoinMessage(err))
 	}