Skip to content

Conversation

micahwoodard
Copy link
Collaborator

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

  • adds aind-dynamic-foraging-basic-analysis as a dependency and uses compute_foraging_efficiency to calculate foraging efficiency

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

  • None

Describe any manual update steps for task computers

  • None

Was this update tested in 446/447?

  • 446/7

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

  • None

@micahwoodard
Copy link
Collaborator Author

@hanhou I'm unsure if I used the correct values for the random_number arg

pyproject.toml Outdated
"aind-auto-train@git+https://github.com/AllenNeuralDynamics/aind-foraging-behavior-bonsai-automatic-training.git@main",
"aind-slims-api@git+https://github.com/AllenNeuralDynamics/aind-slims-api@main",
"aind-dynamic-foraging-models@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-models@main",
"aind-dynamic-foraging-basic-analysis@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-basic-analysis.git@main",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is on Pypi, and has release tags

pyproject.toml Outdated
"newscale@git+https://github.com/AllenNeuralDynamics/python-newscale@axes-on-target",
"aind-auto-train@git+https://github.com/AllenNeuralDynamics/aind-foraging-behavior-bonsai-automatic-training.git@main",
"aind-slims-api@git+https://github.com/AllenNeuralDynamics/aind-slims-api@main",
"aind-dynamic-foraging-models@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-models@main",
Copy link
Collaborator

@alexpiet alexpiet Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this one aind-dynamic-foraging-models

Which you might want to also install from pypi because we recently fixed a dependency issue between foraging models and basic-analysis. I'm not sure if the way you have it now will create a problem, but I think its safer to use pypi

@alexpiet
Copy link
Collaborator

alexpiet commented Oct 2, 2025

@hanhou can you review how the foraging efficiency is being called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants