-
Notifications
You must be signed in to change notification settings - Fork 5
Update foraging eff #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update foraging eff #1624
Conversation
@hanhou I'm unsure if I used the correct values for the random_number arg |
pyproject.toml
Outdated
"aind-auto-train@git+https://github.com/AllenNeuralDynamics/aind-foraging-behavior-bonsai-automatic-training.git@main", | ||
"aind-slims-api@git+https://github.com/AllenNeuralDynamics/aind-slims-api@main", | ||
"aind-dynamic-foraging-models@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-models@main", | ||
"aind-dynamic-foraging-basic-analysis@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-basic-analysis.git@main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo is on Pypi, and has release tags
pyproject.toml
Outdated
"newscale@git+https://github.com/AllenNeuralDynamics/python-newscale@axes-on-target", | ||
"aind-auto-train@git+https://github.com/AllenNeuralDynamics/aind-foraging-behavior-bonsai-automatic-training.git@main", | ||
"aind-slims-api@git+https://github.com/AllenNeuralDynamics/aind-slims-api@main", | ||
"aind-dynamic-foraging-models@git+https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-models@main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is this one aind-dynamic-foraging-models
Which you might want to also install from pypi because we recently fixed a dependency issue between foraging models and basic-analysis. I'm not sure if the way you have it now will create a problem, but I think its safer to use pypi
@hanhou can you review how the foraging efficiency is being called? |
Pull Request instructions:
Describe changes:
What issues or discussions does this update address?
Describe the expected change in behavior from the perspective of the experimenter
Describe any manual update steps for task computers
Was this update tested in 446/447?
Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?