Skip to content

Antalya 25.8 split up build jobs in pull request workflow #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Antalya 25.8 split up build jobs in pull request workflow #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ jobs:

build_amd_tsan:
runs-on: [self-hosted, altinity-on-demand, altinity-builder]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, build_amd_debug, build_amd_release, build_amd_asan, build_amd_binary, build_arm_release, build_arm_binary]
if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF90c2FuKQ==') }}
name: "Build (amd_tsan)"
outputs:
Expand Down Expand Up @@ -458,7 +458,7 @@ jobs:

build_amd_msan:
runs-on: [self-hosted, altinity-on-demand, altinity-builder]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, build_amd_debug, build_amd_release, build_amd_asan, build_amd_binary, build_arm_release, build_arm_binary]
if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9tc2FuKQ==') }}
name: "Build (amd_msan)"
outputs:
Expand Down Expand Up @@ -503,7 +503,7 @@ jobs:

build_amd_ubsan:
runs-on: [self-hosted, altinity-on-demand, altinity-builder]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, build_amd_debug, build_amd_release, build_amd_asan, build_amd_binary, build_arm_release, build_arm_binary]
if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF91YnNhbik=') }}
name: "Build (amd_ubsan)"
outputs:
Expand Down Expand Up @@ -638,7 +638,7 @@ jobs:

build_arm_coverage:
runs-on: [self-hosted, altinity-on-demand, altinity-builder]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
needs: [config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest, build_amd_debug, build_amd_release, build_amd_asan, build_amd_binary, build_arm_release, build_arm_binary]
if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFybV9jb3ZlcmFnZSk=') }}
name: "Build (arm_coverage)"
outputs:
Expand Down
21 changes: 20 additions & 1 deletion ci/workflows/pull_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@
)
]

PRIORITY_BUILD_JOBS = [
job.name
for job in JobConfigs.build_jobs
if any(
substr in job.name
for substr in (
"debug",
"binary",
"asan",
"release",
)
)
]

REGULAR_BUILD_NAMES = [job.name for job in JobConfigs.build_jobs]

workflow = Workflow.Config(
Expand All @@ -36,6 +50,11 @@
# JobNames.STYLE_CHECK, # NOTE (strtgbb): we don't run style check
# JobNames.FAST_TEST, # NOTE (strtgbb): this takes too long, revisit later
# JobConfigs.tidy_build_arm_jobs[0].name, # NOTE (strtgbb): this takes too long, revisit later
*(
PRIORITY_BUILD_JOBS
if job.name not in PRIORITY_BUILD_JOBS
else []
)
]
)
for job in JobConfigs.build_jobs
Expand Down Expand Up @@ -101,7 +120,7 @@
job.set_dependency(FUNCTIONAL_TESTS_PARALLEL_BLOCKING_JOB_NAMES)
for job in JobConfigs.buzz_fuzzer_jobs
],
#*[
# *[
# job.set_dependency(FUNCTIONAL_TESTS_PARALLEL_BLOCKING_JOB_NAMES)
# for job in JobConfigs.performance_comparison_with_master_head_jobs
# ], # NOTE (strtgbb): failed previously due to GH secrets not being handled properly, try again later
Expand Down
Loading