Fix: SR Latch Logic in FlipFlop Gate #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FlipFlop gate was previously implemented with D flip-flop behavior. This commit corrects the Handler function in `gate/flipflop.go` to implement the proper SR latch logic: - S=1, R=0 sets Q=1, Q'=0 - S=0, R=1 sets Q=0, Q'=1 - S=0, R=0 maintains the previous state - The S=1, R=1 input combination, which is typically undefined or forbidden for an SR latch, will continue to set Q=1, Q'=0 as per the previous behavior to maintain compatibility. This behavior is now explicitly documented in the code. A new test suite, `TestFlipFlop_SR_Latch_Logic`, has been added to `gate/flipflop_test.go` to thoroughly verify the corrected SR latch functionality. These tests cover various input combinations, including the enable signal behavior and state maintenance, ensuring the gate behaves as expected. All new tests are passing.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the FlipFlop gate logic so that it behaves as an SR latch rather than a D flip-flop, and it adds comprehensive tests for the corrected behavior.
- Correct SR latch behavior is implemented in the Handler function.
- A new test suite in gate/flipflop_test.go validates SR latch functionality under various input scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gate/flipflop.go | Updated Handler to implement proper SR latch logic and document S=1,R=1 behavior. |
| gate/flipflop_test.go | Added extensive tests to verify SR latch logic and enable transitions. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FlipFlop gate was previously implemented with D flip-flop behavior. This commit corrects the Handler function in
gate/flipflop.goto implement the proper SR latch logic:A new test suite,
TestFlipFlop_SR_Latch_Logic, has been added togate/flipflop_test.goto thoroughly verify the corrected SR latch functionality. These tests cover various input combinations, including the enable signal behavior and state maintenance, ensuring the gate behaves as expected. All new tests are passing.