Remove onRedirectNavigate from endSessionRequest #8066
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the onRedirectNavigate parameter from the EndSessionRequest interface, consolidating navigation control to the global configuration level. The change simplifies the logout API by removing request-level navigation overrides while maintaining the callback functionality in the main configuration.
- Removes
onRedirectNavigatefromEndSessionRequesttype definition - Updates sample code to remove usage of the parameter
- Removes comprehensive test coverage for the parameter functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/msal-browser/src/request/EndSessionRequest.ts |
Removes onRedirectNavigate property from type definition |
lib/msal-browser/src/interaction_client/RedirectClient.ts |
Simplifies logout logic by removing onRedirectNavigate handling |
lib/msal-browser/test/interaction_client/RedirectClient.spec.ts |
Removes tests for onRedirectNavigate parameter behavior |
samples/msal-react-samples/react-router-sample/src/pages/Logout.jsx |
Removes onRedirectNavigate usage from sample |
samples/msal-react-samples/b2c-sample/src/pages/Logout.jsx |
Removes onRedirectNavigate usage from sample |
samples/msal-browser-samples/ChromiumExtensionSample/auth.js |
Simplifies logout implementation |
samples/msal-browser-samples/ChromiumExtensionSample/README.md |
Updates documentation to reflect API changes |
lib/msal-browser/docs/v4-migration.md |
Documents breaking change for migration |
lib/msal-browser/docs/logout.md |
Removes documentation for removed functionality |
lib/msal-browser/apiReview/msal-browser.api.md |
Updates API surface documentation |
change/@azure-msal-browser-88e0dc39-07d7-4080-a5bb-96379561a4ff.json |
Beachball change file for major version bump |
Co-authored-by: Sameera Gajjarapu <[email protected]>
Co-authored-by: Sameera Gajjarapu <[email protected]>
| ); | ||
| }); | ||
|
|
||
| it("doesnt navigate if onRedirectNavigate returns false", (done) => { |
There was a problem hiding this comment.
Just want to double check: do we have these tests somewhere for using the PCA config option?
There was a problem hiding this comment.
Yes, it's further down in the file
There was a problem hiding this comment.
Could you link me to them, I only see ones for acquireToken not for logout?
There was a problem hiding this comment.
You're right, it's for acquireToken. I'll add some logout tests
Co-authored-by: Sameera Gajjarapu <[email protected]>
Co-authored-by: Sameera Gajjarapu <[email protected]>
Removes onRedirectNavigate from endSessionRequest with test and documentation updates.
onRedirectNavigate will remain in Configuration.