-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Native Auth] Enable MFA and JIT for SMS in public interfaces #8069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables Multi-Factor Authentication (MFA) and Just-in-Time (JIT) registration for SMS channels in the public interfaces of the MSAL browser custom authentication library. The changes integrate MFA client support throughout authentication flows and provide comprehensive test coverage for both MFA and JIT scenarios across sign-up, sign-in, and password reset flows.
- Adds MfaClient dependency injection to all authentication state parameters and controllers
- Updates result types to support MFA-required states alongside existing JIT support
- Extends integration tests to cover MFA and JIT flows with both email and SMS channels
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
Test files (*.spec.ts) | Add MfaClient mock setup and comprehensive test coverage for MFA/JIT scenarios |
State parameter files | Add mfaClient property to enable MFA support across all authentication flows |
State implementation files | Integrate MfaClient into state transitions and result handling |
Result type files | Add MFA-required state support and type checking methods |
Controller and client files | Wire up MfaClient dependency injection and MFA flow handling |
Index file | Export MFA-related types and classes for public API |
No description provided.