Stop setting isBroker in initialize #8075
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the isBroker parameter from the initialize method across the MSAL browser library as part of changes to the broker model that make this flag unnecessary.
- Removes the
isBrokerparameter from theinitializemethod signature in controllers and interfaces - Simplifies the initialization logic by removing broker-specific conditional code
- Updates tests to reflect the simplified initialization interface
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/msal-browser/src/controllers/IController.ts |
Updates interface to remove isBroker parameter from initialize method |
lib/msal-browser/src/controllers/StandardController.ts |
Removes isBroker parameter and conditional broker logic from initialize method |
lib/msal-browser/src/controllers/NestedAppAuthController.ts |
Removes unused isBroker parameter from initialize method |
lib/msal-browser/src/app/PublicClientApplication.ts |
Updates call to controller initialize to remove isBroker argument |
lib/msal-browser/test/app/PublicClientApplication.spec.ts |
Removes test that verified isBroker parameter passing |
lib/msal-browser/apiReview/msal-browser.api.md |
Updates API documentation to reflect removed parameter |
change/@azure-msal-browser-08e8affc-ae18-41c2-821d-112c37fbdbdb.json |
Beachball change file for tracking this patch-level change |
sameerag
approved these changes
Oct 2, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "patch", | |||
| "comment": "Remove isBroker flag from initialize", | |||
There was a problem hiding this comment.
Suggested change
| "comment": "Remove isBroker flag from initialize", | |
| "comment": "Remove isBroker flag from initialize, #8075 ", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the broker model make the isBroker flag unnecessary, removing.