Skip to content

Sharon Dong submission #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Sharon Dong submission #2

wants to merge 17 commits into from

Conversation

sharond106
Copy link

No description provided.

@likangning93
Copy link

Hi Sharon! Some HW01 grading notes

  • grading based on https://github.com/sharond106/hw00-webgl-intro - please submit a pull request to the homework assignment's repository next time so we can find your work
  • normals method seems a bit complex - I'm not sure I follow generating normals using both the polar method and the tangent/bitangent method. But the tangent/bitangent method looks correct.
  • moon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharond106 @likangning93