-
Notifications
You must be signed in to change notification settings - Fork 48
Project 3: Logan Cho #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
logancho
wants to merge
67
commits into
CIS5650-Fall-2024:main
Choose a base branch
from
logancho:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port for textures or bounding volume optimization yet.
…nterp working. Also need to test if tex sampling works in the first place..
…O: Extract UV coordinates during model loading process.
…n done. Need to have per triangle textureIndexing now!
…pport 1 mesh .gltf file with multiple primitives, materials and textures! Will stick with 1 file for now.
…tored and cleaned up material related code.
…t for some renders I want to do. This project has been a ton of fun
…bsdf for a naive glossy ceramic.
… path to full lighting Li for the best possible renders.
…ults. Diamond material looks especially cool in the cornell box
…ow .. not sure what the cause is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 0 late days. I understand how late this submission is and completely understand if I get a 0 for it.
With this assignment especially, I had so much fun and regardless of the grade, I wanted to submit something I was proud of. And I'm thankful that I think it's gotten to that point! I never thought I would enjoy path tracing this much.
For grading purposes: