Add Travis Continuous Integration to the repo #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's already found a pile of typos: |
Contributor
Author
|
Typos all fixed. |
Contributor
Author
|
This now all passes apart from these two, which looks like genuine failures (on Teensy 3.5/6): |
Contributor
Author
|
Hi @adrianfreed, What's your feeling on this? Should Teensy 3.5/6 be supported? Are you expecting the UDPSendBundlewithTimeTag examples to work on those platforms? Should I mark those as expected failures for now so the bulk of Travis can be merged in and the spelling fixes? |
Resync with master
peternewman
changed the title
Merged
Resync with master
peternewman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To catch careless typos etc.
You'll need to enable Travis on the repo (https://travis-ci.com is now the recommended option), and I'd then suggest you protect the branch in GitHub so you can only merge if Travis passes.
Currently this is just testing against the some Teensy version, we could test against a lot more variations if it's worth it (many examples, many platforms):
http://platformio.org/boards
We could also enable a C++ linter if you have a preferred one, or use cpplint.py from Google?