Skip to content

Changes to fix theme names while migrating app that is generated through sencha architect #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: ext-gen-7.9.x-rapid-fixes
Choose a base branch
from
Open

Changes to fix theme names while migrating app that is generated through sencha architect #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2188e78
Changes to fix theme names while migrating app that is generated thr…
narendrarbabu Feb 27, 2025
0773f5b
code format changes
narendrarbabu Feb 28, 2025
6cef9cb
Update appMigrate.js
GovardhanCel Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions packages/ext-gen/appMigrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ var gitIgnore = '.gitIgnore';
var gitIgnoreAppend = '/generatedFiles ' + os.EOL + '/cordova ' + os.EOL + '/node_modules' + os.EOL;
var gitIgnoreData = '/build ' + os.EOL + gitIgnoreAppend;
var extFrameworkPath = 'node_modules/@sencha/ext';
var themes = ['theme-base', 'theme-ios', 'theme-material',
'theme-aria', 'theme-neutral', 'theme-classic', 'theme-gray',
'theme-crisp', 'theme-crisp-touch', 'theme-neptune', 'theme-neptune-touch',
'theme-triton', 'theme-graphite'];
var classic = false;
var modern = false;
var universal = false;
Expand Down Expand Up @@ -340,10 +344,6 @@ function removeDebugJsPath(jsonLocation) {

function handleWorkspaceJsonmigrate() {
var workspaceJsonObject = getJson(workspaceJson),
themes = ['theme-base', 'theme-ios', 'theme-material',
'theme-aria', 'theme-neutral', 'theme-classic', 'theme-gray',
'theme-crisp', 'theme-crisp-touch', 'theme-neptune', 'theme-neptune-touch',
'theme-triton', 'theme-graphite'],
packageNames = ['treegrid', 'calendar', 'charts', 'froala-editor', 'amf', 'd3',
'exporter', 'pivot', 'pivot-d3', 'pivot-locale', 'ux', 'font-ios'],
basePath = '$\u007Bworkspace.dir}/node_modules/@sencha/ext-',
Expand Down Expand Up @@ -513,11 +513,11 @@ function buildToolKitAndThemeDetails() {
if (appJsonObject.hasOwnProperty('toolkit')) {
if (appJsonObject.toolkit == classicProfile) {
classic = true;
classicTheme = appJsonObject.theme;
classicTheme = appJsonObject.theme = verifyAndUpdateTheme(appJsonObject.theme);
}
else {
modern = true;
modernTheme = appJsonObject.theme;
modernTheme = appJsonObject.theme = verifyAndUpdateTheme(appJsonObject.theme);
}
}
else {
Expand All @@ -532,12 +532,32 @@ function buildToolKitAndThemeDetails() {
for (profile in appJsonObject.builds) {
if (profile === classicProfile) {
classic = true;
classicTheme = appJsonObject.builds[profile].theme;
classicTheme = appJsonObject.builds[profile].theme = verifyAndUpdateTheme(appJsonObject.builds[profile].theme);
}
if (profile == modernProfile) {
modern = true;
modernTheme = appJsonObject.builds[profile].theme;
modernTheme = appJsonObject.builds[profile].theme = verifyAndUpdateTheme(appJsonObject.builds[profile].theme);
}
}
}
}

function verifyAndUpdateTheme(appTheme) {
var themeStr = appTheme.replace(/[^a-z-]/g, ''),
matchedTheme;

// once special chars are removed check if it is one of the existing themes
if (themes.indexOf(themeStr) >= 0) {
return themeStr;
}

// if doesn't exists return the appropriate theme from built-in theme list
for (var i = 0; i < themes.length; i++) {
if (themeStr.includes(themes[i])) {
matchedTheme = themes[i];
break;
}
}
return matchedTheme ? matchedTheme : appTheme;
}