Skip to content

Improved pylint score of Basemodule #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improved pylint score of Basemodule #4618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fdb238
fixed pylint errors in utils.py
Sekhar-Kumar-Dash Apr 27, 2025
55501c3
fixed pylint errors in models.py
Sekhar-Kumar-Dash Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/base/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ class Meta:

def model_field_name(field_name, *args, **kwargs):
"""
The decorator is used to pass model field names to create_post_model_field function for logging change.
The decorator is used to pass model field names to
create_post_model_field function for logging change.
"""

def model_field_name_decorator(f, *args, **kwargs):
Expand Down
21 changes: 14 additions & 7 deletions apps/base/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def get_model_by_pk(pk):

def encode_data(data):
"""
Turn `data` into a hash and an encoded string, suitable for use with `decode_data`.
Turn `data` into a hash and an encoded string,
suitable for use with `decode_data`.
"""
encoded = []
for i in data:
Expand Down Expand Up @@ -114,7 +115,8 @@ def send_email(
sender {string} -- Email of sender (default: {settings.TEAM_EMAIL})
recipient {string} -- Recipient email address
template_id {string} -- Sendgrid template id
template_data {dict} -- Dictionary to substitute values in subject and email body
template_data {dict} --
Dictionary to substitute values in subject and email body
"""
try:
sg = sendgrid.SendGridAPIClient(
Expand All @@ -132,7 +134,8 @@ def send_email(
sg.client.mail.send.post(request_body=mail.get())
except Exception:
logger.warning(
"Cannot make sendgrid call. Please check if SENDGRID_API_KEY is present."
"Cannot make sendgrid call. "
"Please check if SENDGRID_API_KEY is present."
)
return

Expand All @@ -150,7 +153,8 @@ def get_boto3_client(resource, aws_keys):
"""
Returns the boto3 client for a resource in AWS
Arguments:
resource {str} -- Name of the resource for which client is to be created
resource {str} --
Name of the resource for which client is to be created
aws_keys {dict} -- AWS keys which are to be used
Returns:
Boto3 client object for the resource
Expand Down Expand Up @@ -250,8 +254,10 @@ def send_slack_notification(webhook=settings.SLACK_WEB_HOOK_URL, message=""):
"""
Send slack notification to any workspace
Keyword Arguments:
webhook {string} -- slack webhook URL (default: {settings.SLACK_WEB_HOOK_URL})
message {str} -- JSON/Text message to be sent to slack (default: {""})
webhook {string} --
slack webhook URL (default: {settings.SLACK_WEB_HOOK_URL})
message {str} --
JSON/Text message to be sent to slack (default: {""})
"""
try:
data = {
Expand All @@ -267,7 +273,8 @@ def send_slack_notification(webhook=settings.SLACK_WEB_HOOK_URL, message=""):
)
except Exception as e:
logger.exception(
"Exception raised while sending slack notification. \n Exception message: {}".format(
"Exception raised while sending slack notification."
" \n Exception message: {}".format(
e
)
)
Expand Down