-
-
Notifications
You must be signed in to change notification settings - Fork 878
Introduce SQS VisibilityTimeout
#4650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4650 +/- ##
==========================================
- Coverage 72.93% 69.67% -3.26%
==========================================
Files 83 21 -62
Lines 5368 3608 -1760
==========================================
- Hits 3915 2514 -1401
+ Misses 1453 1094 -359 see 73 files with indirect coverage changes see 73 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Hi @dabico , Thanks for the PR and it looks correct. Can you please tell us for which challenge do you need this feature? |
Hello @RishabhJain2018, thanks for the prompt response! JetBrains is currently running a Context Collection Competition with Mistral on EvalAI. We initially had the idea of processing user submissions with multiple workers, hence the need for introducing support for |
Hi @dabico , Awesome, thanks for the explanation. I'll go ahead and merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Currently only
MessageRetentionPeriod
period can be customized. This PR also adds the ability to customizeVisibilityTimeout
, useful in cases where parallel workers might be involved. In essence, this setting allows users to customize the time delay between which a retrieved queue message will be unavailable on further requests (without actually removing it from the queue). By default, it's 30 seconds, but users can in/decrease this amount to their liking.