Skip to content

Conversation

dabico
Copy link

@dabico dabico commented Jun 7, 2025

Currently only MessageRetentionPeriod period can be customized. This PR also adds the ability to customize VisibilityTimeout, useful in cases where parallel workers might be involved. In essence, this setting allows users to customize the time delay between which a retrieved queue message will be unavailable on further requests (without actually removing it from the queue). By default, it's 30 seconds, but users can in/decrease this amount to their liking.

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (96968d6) to head (8572988).
Report is 1185 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
- Coverage   72.93%   69.67%   -3.26%     
==========================================
  Files          83       21      -62     
  Lines        5368     3608    -1760     
==========================================
- Hits         3915     2514    -1401     
+ Misses       1453     1094     -359     

see 73 files with indirect coverage changes

see 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573bab3...8572988. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RishabhJain2018
Copy link
Member

Hi @dabico , Thanks for the PR and it looks correct. Can you please tell us for which challenge do you need this feature?

@RishabhJain2018 RishabhJain2018 self-requested a review June 8, 2025 23:14
@dabico
Copy link
Author

dabico commented Jun 10, 2025

Hello @RishabhJain2018, thanks for the prompt response! JetBrains is currently running a Context Collection Competition with Mistral on EvalAI. We initially had the idea of processing user submissions with multiple workers, hence the need for introducing support for VisibilityTimeout. However, the volume of submissions we are receiving at the moment is adequate for a single worker. For this reason, I don't consider pushing this change to production to be of top-most priority for us now. Still, I saw an opportunity to make a contribution to the platform by adding a (hopefully) useful feature for everyone!

@RishabhJain2018
Copy link
Member

Hi @dabico , Awesome, thanks for the explanation. I'll go ahead and merge this!

Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants