Skip to content

Fix #4707: Clean up HTML structure and metadata in base.html #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #4707: Clean up HTML structure and metadata in base.html #4707

wants to merge 1 commit into from

Conversation

cooldeba-21
Copy link

@cooldeba-21 cooldeba-21 commented Jun 28, 2025 •
edited
Loading

Summary

This PR makes the following improvements to base.html:

  • ✅ Ensured secure script sourcing (HTTPS used for all external scripts)
  • 🧹 Removed deprecated or outdated items:
    • Removed html5shiv (no longer needed)
    • Removed cdn.mathjax.org (switched to a maintained CDN)
  • ✨ Cleaned up and de-duplicated metadata for better SEO and clarity
  • 💡 Preserved the AngularJS SPA structure of EvalAI
  • 💬 Added inline comments for GSoC readability and future maintainers

Checklist

  • Code changes are consistent with the overall project style
  • PR is small and focused on a single improvement
  • All CI checks have passed
  • PR ready for review by mentors

Fixes

None directly, but improves maintainability and frontend best practices.

Notes

Please review and merge if everything looks good. Thanks! 🙌

cc @mentor

@cooldeba-21
Update base.html
ed7cac7 
Ensured secure script sourcing (HTTPS everywhere).

Removed deprecated or outdated items like html5shiv and cdn.mathjax.org.

Cleaned up metadata.

Preserved structure appropriate for an AngularJS SPA, since that's what EvalAI uses.

Added comments for GSoC-readiness.
@cooldeba-21
Copy link
Author

cooldeba-21 commented Jun 29, 2025 •
edited
Loading

✅ All Travis CI checks have passed successfully.

This PR is ready for your review. Please let me know if there’s anything I should improve. Thank you!
Mentors: Could you please add the ready-for-review or review-needed label to this PR? Thank you!
@mentor_CI Could you please review this PR when you get time? 🙂

cooldeba-21
cooldeba-21 commented Jun 29, 2025
View reviewed changes
Copy link
Author

@cooldeba-21 cooldeba-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR improves the structure of base.html by:

  • Removing duplicate meta tags
  • Updating MathJax and Analytics
  • Cleaning up the head section for better HTML5 standards

✅ All tests and CI checks have passed.

Ready for review 🚀

@cooldeba-21 cooldeba-21 changed the title Update base.html Fix: Clean up HTML structure and metadata in base.html Jun 29, 2025
@cooldeba-21 cooldeba-21 changed the title Fix: Clean up HTML structure and metadata in base.html Fix #4707: Clean up HTML structure and metadata in base.html Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cooldeba-21