Skip to content

Conversation

Akshat453
Copy link
Contributor

@Akshat453 Akshat453 commented Jul 18, 2025

Fixes: #4674

All Challenges:
https://github.com/user-attachments/assets/5bb11af1-b3cc-4e88-9708-4994c06996dd

Hosted Challenges:
https://github.com/user-attachments/assets/f1dcffb6-39b4-4284-87d8-29505ed6c9d0

Features Implemented:
Added filter dialog for All Challenges and Hosted Challenges:

  • Search Bar(Search by title ,tag or domain name)
  • Filter by Start Date and End Date(All the challenges between the selected dates will appear)
  • Sort by Domain
  • Sort by Host Team
  • Sort by Team Name (Ascending/Descending)

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 94.91525% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (96968d6) to head (f96c3b1).
Report is 1228 commits behind head on master.

Files with missing lines Patch % Lines
frontend/src/js/controllers/challengeListCtrl.js 93.18% 6 Missing ⚠️
frontend/src/js/controllers/hostedChallengeCtrl.js 95.94% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4749      +/-   ##
==========================================
+ Coverage   72.93%   77.65%   +4.72%     
==========================================
  Files          83       22      -61     
  Lines        5368     3769    -1599     
==========================================
- Hits         3915     2927     -988     
+ Misses       1453      842     -611     
Files with missing lines Coverage Δ
frontend/src/js/controllers/filterDialogCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/hostedChallengeCtrl.js 97.69% <95.94%> (-2.31%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.65% <93.18%> (+0.97%) ⬆️

... and 73 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/filterDialogCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/hostedChallengeCtrl.js 97.69% <95.94%> (-2.31%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.65% <93.18%> (+0.97%) ⬆️

... and 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158473a...f96c3b1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Akshat453
Copy link
Contributor Author

Hey @RishabhJain2018 Can you review this Pr?

@Akshat453 Akshat453 marked this pull request as ready for review July 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant